Skip to content

Commit fb073e5

Browse files
committed
Addressing PR feedback and rebasing to master
1 parent 75406d5 commit fb073e5

File tree

5 files changed

+3
-5
lines changed

5 files changed

+3
-5
lines changed

eng/testing/linker/SupportFiles/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<IsTrimmingTest>true</IsTrimmingTest>
3+
<UseDefaultBlazorWASMFeatureSwitches>false</UseDefaultBlazorWASMFeatureSwitches>
44
<PublishTrimmed>true</PublishTrimmed>
55
<SkipImportRepoLinkerTargets>true</SkipImportRepoLinkerTargets>
66
<TrimMode>link</TrimMode>

eng/testing/linker/SupportFiles/Directory.Build.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
Condition="'$(TargetArchitecture)' == 'wasm' And '$(TargetOs)' == 'browser'" />
4343

4444
<!-- Overriding these targets as these projects won't need to binplace -->
45-
<Target Name="GetBinPlaceTargetFramework" />
4645
<Target Name="PublishTestAsSelfContained" />
4746

4847
</Project>

eng/testing/linker/project.csproj.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
<OutputType>Exe</OutputType>
55
<MonoAOTCompilerDir>{MonoAOTCompilerDir}</MonoAOTCompilerDir>
66
<MonoProjectRoot>{MonoProjectRoot}</MonoProjectRoot>
7+
<EventSourceSupport>true</EventSourceSupport>
78
<MonoAOTCompilerTasksAssemblyPath>{MonoAOTCompilerTasksAssemblyPath}</MonoAOTCompilerTasksAssemblyPath>
89
<WasmAppBuilderTasksAssemblyPath>{WasmAppBuilderTasksAssemblyPath}</WasmAppBuilderTasksAssemblyPath>
9-
<ILLinkTasksAssembly>{ILLinkTasksAssembly}</ILLinkTasksAssembly>
1010
<MicrosoftNetCoreAppRuntimePackRidDir>{MicrosoftNetCoreAppRuntimePackRidDir}</MicrosoftNetCoreAppRuntimePackRidDir>
1111
<RepositoryEngineeringDir>{RepositoryEngineeringDir}</RepositoryEngineeringDir>
1212
<TargetFramework>{NetCoreAppCurrent}</TargetFramework>

eng/testing/linker/trimmingTests.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
.Replace('{MonoProjectRoot}', '$(MonoProjectRoot)')
8383
.Replace('{MonoAOTCompilerTasksAssemblyPath}', '$(MonoAOTCompilerTasksAssemblyPath)')
8484
.Replace('{WasmAppBuilderTasksAssemblyPath}', '$(WasmAppBuilderTasksAssemblyPath)')
85-
.Replace('{ILLinkTasksAssembly}', '$(ILLinkTasksAssembly)')
8685
.Replace('{MicrosoftNetCoreAppRuntimePackRidDir}', '$(MicrosoftNetCoreAppRuntimePackRidDir)'))"
8786
Overwrite="true" />
8887
<Copy SourceFiles="$(_projectSourceFile)"

eng/testing/tests.mobile.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<PublishingTestsRun>true</PublishingTestsRun>
1111
</PropertyGroup>
1212

13-
<PropertyGroup Condition="'$(TargetOS)' == 'Browser' And '$(IsTrimmingTest)' != 'true'">
13+
<PropertyGroup Condition="'$(TargetOS)' == 'Browser' And '$(UseDefaultBlazorWASMFeatureSwitches)' != 'false'">
1414
<!-- We need to set this in order to get extensibility on xunit category traits and other arguments we pass down to xunit via MSBuild properties -->
1515
<RunScriptCommand Condition="'$(IsFunctionalTest)' != 'true'">$HARNESS_RUNNER wasm $XHARNESS_COMMAND --app=. --engine=$(JSEngine) $(JSEngineArgs) --js-file=runtime.js --output-directory=$XHARNESS_OUT -- $(RunTestsJSArguments) --run WasmTestRunner.dll $(AssemblyName).dll</RunScriptCommand>
1616
<RunScriptCommand Condition="'$(IsFunctionalTest)' == 'true'">$HARNESS_RUNNER wasm $XHARNESS_COMMAND --app=. --engine=$(JSEngine) $(JSEngineArgs) --js-file=runtime.js --output-directory=$XHARNESS_OUT --expected-exit-code=$(ExpectedExitCode) -- $(RunTestsJSArguments) --run $(AssemblyName).dll --testing</RunScriptCommand>

0 commit comments

Comments
 (0)