chore: Refactor the slice filter for entity search

Author: christian-kreuzberger-dtx

src/index.ts

@@ -474,13 +474,16 @@ const main = async () => {
       const smartscapeResult = await findMonitoredEntityViaSmartscapeByName(dtClient, entityNames);
 
       if (smartscapeResult && smartscapeResult.records && smartscapeResult.records.length > 0) {
-        let resp = `Found ${smartscapeResult.records.length} monitored entities via Smartscape! Displaying the first ${maxEntitiesToDisplay} entities:\n`;
+        // Filter valid entities first, to ensure we display up to maxEntitiesToDisplay entities
+        const validSmartscapeEntities = smartscapeResult.records.filter(
+          (entity): entity is { id: string; type: string; name: string; [key: string]: any } =>
+            !!(entity && entity.id && entity.type && entity.name),
+        );
 
-        // iterate over dqlResponse and create a string with the problem details, but only show the top maxEntitiesToDisplay problems
-        smartscapeResult.records.slice(0, maxEntitiesToDisplay).forEach((entity) => {
-          if (entity && entity.id && entity.type && entity.name) {
-            resp += `- Entity '${entity.name}' of entity-type '${entity.type}' has entity id '${entity.id}' and tags ${entity['tags'] ? JSON.stringify(entity['tags']) : 'none'} - DQL Filter: '| filter dt.smartscape.${String(entity.type).toLowerCase()} == "${entity.id}"'\n`;
-          }
+        let resp = `Found ${validSmartscapeEntities.length} monitored entities via Smartscape! Displaying the first ${Math.min(maxEntitiesToDisplay, validSmartscapeEntities.length)} valid entities:\n`;
+
+        validSmartscapeEntities.slice(0, maxEntitiesToDisplay).forEach((entity) => {
+          resp += `- Entity '${entity.name}' of entity-type '${entity.type}' has entity id '${entity.id}' and tags ${entity['tags'] ? JSON.stringify(entity['tags']) : 'none'} - DQL Filter: '| filter dt.smartscape.${String(entity.type).toLowerCase()} == "${entity.id}"'\n`;
         });
 
         // ToDo: Refine next-steps, this is not working properly yet.
@@ -499,10 +502,16 @@ const main = async () => {
       const result = await findMonitoredEntitiesByName(dtClient, entityNames, extendedSearch);
 
       if (result && result.records && result.records.length > 0) {
-        let resp = `Found ${result.records.length} monitored entities! Displaying the first ${maxEntitiesToDisplay} entities:\n`;
+        // Filter valid entities first, to ensure we display up to maxEntitiesToDisplay entities
+        const validClassicEntities = result.records.filter(
+          (entity): entity is { id: string; type: string; name: string; [key: string]: any } =>
+            !!(entity && entity.id && entity.type && entity.name),
+        );
+
+        let resp = `Found ${validClassicEntities.length} monitored entities! Displaying the first ${Math.min(maxEntitiesToDisplay, validClassicEntities.length)} entities:\n`;
 
         // iterate over dqlResponse and create a string with the problem details, but only show the top maxEntitiesToDisplay problems
-        result.records.slice(0, maxEntitiesToDisplay).forEach((entity) => {
+        validClassicEntities.slice(0, maxEntitiesToDisplay).forEach((entity) => {
           if (entity && entity.id) {
             const entityType = getEntityTypeFromId(String(entity.id));
             resp += `- Entity '${entity['entity.name']}' of entity-type '${entity['entity.type']}' has entity id '${entity.id}' and tags ${entity['tags'] ? entity['tags'] : 'none'} - DQL Filter: '| filter ${entityType} == "${entity.id}"'\n`;