fix(models): keep_batch_sharded false logic#912
Merged
Conversation
havardhhaugen
added
bug
havardhhaugen
changed the title
havardhhaugen
changed the title
Contributor
ssmmnn11
approved these changes
Feb 24, 2026
Member
ssmmnn11
left a comment
ssmmnn11
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM! At some point we should introduce regression tests for this.
github-project-automation
bot
moved this from To be triaged
to For merging
in Anemoi-dev
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the logic to check
in_out_shardedin models - which needs to be a dict now thatshard_shapesis a dict. In the pr I have fixed the issue for the following modelsStill todo:
I'm not that familiar with the remaining models, but I can look into it. However if someone think they can fix it fast I would be happy with some help.
What problem does this change solve?
Currently training with model sharding and keep_batch_sharded: False fails with a shape error in the allgather due to the logical error described above.
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.