feat!: Rewrite dataset Schema to fix issue 911#916
Conversation
|
LGTM, running some jobs with this rn |
|
Ok, for me as well. [didn't have time to look in detail though] |
4669d8e to
502e372
Compare
|
@ecmwf/anemoi_technical_subgroup - this PR was discussed an agreed that the breaking changes were accepted. Implementation details should be discussed at PR level. |
|
Many thanks @dietervdb-meteo @icedoom888! I am running now the integration tests to confirm. Dieter, the current implementation leaves start/end to be outside keys (not inside the dataset_config). There is check/test that those can't be passed in the inside level to avoid confusion. What do you think about this ? |
|
Hi @anaprietonem, thanks. I found peace with leaving start and end as separate arguments :) So far so good. Not sure if a check on forbidding them inside is a good idea? Are we sure this still allows use cases where e.g. a user concatenates two datasets by providing start and end for each of them, then selects sub periods for training and validation by providing start and end in the dataloader? |
|
I.e. although I see the point of a check to avoid confusion, we should make sure it doesn't exclude valid use cases that existed before. Maybe a warning? Or just leave it as is? [We had the 'confusing' situation before as well] |
There was a problem hiding this comment.
Ok, with the current config layout. As @JPXKQX wrote we can revisit at a later stage in a wider context.
|
Tested and working! |
Description
Breaking change to dataloader dataset config: per-dataset reader options now use dataset_config with dataset as the source key (inner key), aligned with open_dataset({"dataset": ..., ...}).
This PR updates:
Old dataset/name shapes are no longer supported.
What problem does this change solve?
#911
What issue or task does this change relate to?
#911
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--916.org.readthedocs.build/en/916/
📚 Documentation preview 📚: https://anemoi-graphs--916.org.readthedocs.build/en/916/
📚 Documentation preview 📚: https://anemoi-models--916.org.readthedocs.build/en/916/