feat(graphs): add custom area weightings#926
Merged
JPXKQX merged 14 commits intoecmwf:mainfrom Feb 24, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…e to docs about selecting the first timestep.
for more information, see https://pre-commit.ci
JPXKQX
reviewed
Feb 24, 2026
Member
|
Hi @efare04, this PR looks self-contained and provides some new functionality. Thanks for your contribution! I made a minor comment, but I'm happy to approve! |
Contributor
Author
|
Hi @JPXKQX, thanks for the review! I've updated the docstring to remove the private method. Just to quickly follow up on my original comment, I'm happy to rename and relocate |
Member
|
I think it's fine for now. If we identify any new use cases that reuse this functionality, we could consider abstracting it. |
JPXKQX
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a class which allows users to load custom area weightings from a variable in an Anemoi dataset. The behaviour of
AnemoiDatasetVariableWeightsis based on that ofBaseAnemoiDatasetVariable, but isn't inherited directly from that class as that would setdtype = bool.What problem does this change solve?
None of the existing classes to calculate area weightings are suitable for the tripolar ORCA025 grid, but we already have a file containing the cell areas. This information could be read directly from a variable in an Anemoi dataset into a node attribute, rather than calculating the area weightings within
anemoi-graphs.What issue or task does this change relate to?
#925
Additional notes
I've put this in
area_weights.py, as we're intending to use it for area weightings, but this class could be used to create a custom node attribute for other purposes. Perhaps it would be worth renaming it (e.g. toAnemoiDatasetVariableAttribute) and moving it elsewhere, as its application isn't limited to area weights?As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--926.org.readthedocs.build/en/926/
📚 Documentation preview 📚: https://anemoi-graphs--926.org.readthedocs.build/en/926/
📚 Documentation preview 📚: https://anemoi-models--926.org.readthedocs.build/en/926/