Skip to content

Commit b1a7027

Browse files
It uses docker compose command instead of the now deprecated old docker-compose (second part).
1 parent 5331e8a commit b1a7027

6 files changed

Lines changed: 9 additions & 9 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Once your changes and tests are ready to submit for review:
6060

6161
Ensure that all tests pass by running `make check-all`. This runs sequentially lint checks, unit tests and integration tests. These can be executed in isolation using `make lint`, `make test` and `make it` respectively, in case you need to iterate over a subset of tests.
6262

63-
Note: Integration tests are much slower than unit tests and require `docker-compose`.
63+
Note: Integration tests are much slower than unit tests and require `docker compose`.
6464

6565
3. Sign the Contributor License Agreement
6666

docs/developing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Install the following software packages:
88

99
* `uv <https://docs.astral.sh/uv/getting-started/installation/>`_
1010
* JDK version required to build Elasticsearch. Please refer to the `build setup requirements <https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-to-the-elasticsearch-codebase>`_.
11-
* `Docker <https://docs.docker.com/install/>`_ and on Linux additionally `docker-compose <https://docs.docker.com/compose/install/>`_.
11+
* `Docker <https://docs.docker.com/install/>`_ and on Linux additionally `docker compose <https://docs.docker.com/compose/install/>`_.
1212
* `jq <https://stedolan.github.io/jq/download/>`_
1313
* git
1414

recipes/ccr/start.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ set -e
44
source .elastic-version
55

66
# Start metrics store
7-
docker-compose -f ./metricstore-docker-compose.yml up -d
7+
docker compose -f ./metricstore-docker-compose.yml up -d
88

99
# Start Elasticsearch
10-
docker-compose up -d
10+
docker compose up -d
1111

1212
printf "Waiting for clusters to get ready "
1313

recipes/ccr/stop.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env bash
22
source .elastic-version
33

4-
docker-compose down -v
5-
docker-compose -f metricstore-docker-compose.yml down -v
4+
docker compose down -v
5+
docker compose -f metricstore-docker-compose.yml down -v

release-docker-test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function check_prerequisites {
3232
exit 1
3333
fi
3434

35-
if ! type docker-compose > /dev/null; then
35+
if ! type docker compose > /dev/null; then
3636
echo "docker compose is necessary to run the integration tests"
3737
exit 1
3838
fi

tests/mechanic/launcher_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ class TestDockerLauncher:
347347
@mock.patch("esrally.utils.process.run_subprocess_with_output")
348348
def test_starts_container_successfully(self, run_subprocess_with_output, run_subprocess_with_logging):
349349
run_subprocess_with_logging.return_value = 0
350-
# Docker container id (from docker-compose ps), Docker container id (from docker ps --filter ...)
350+
# Docker container id (from docker compose ps), Docker container id (from docker ps --filter ...)
351351
run_subprocess_with_output.side_effect = [["de604d0d"], ["de604d0d"]]
352352
cfg = config.Config()
353353
docker = launcher.DockerLauncher(cfg)
@@ -386,7 +386,7 @@ def test_starts_container_successfully(self, run_subprocess_with_output, run_sub
386386
@mock.patch("esrally.utils.process.run_subprocess_with_output")
387387
def test_container_not_started(self, run_subprocess_with_output, run_subprocess_with_logging, sleep):
388388
run_subprocess_with_logging.return_value = 0
389-
# Docker container id (from docker-compose ps), but NO Docker container id (from docker ps --filter...) twice
389+
# Docker container id (from docker compose ps), but NO Docker container id (from docker ps --filter...) twice
390390
run_subprocess_with_output.side_effect = [["de604d0d"], [], []]
391391
cfg = config.Config()
392392
# ensure we only check the status two times

0 commit comments

Comments
 (0)