Skip to content

Commit 7ff95ca

Browse files
naderhendevelar
authored andcommitted
fix(mac): clean macOsVersion before gte comparison (#1733)
* Clean macOsVersion before gte comparison Since 10.12 is a possible Sierra version, clean before doing comparison to avoid "Invalid Version" error from SemVer
1 parent 0a98870 commit 7ff95ca

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

packages/electron-builder/src/util/macosVersion.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ function clean(version: string) {
1717

1818
/** @internal */
1919
export async function isOsVersionGreaterThanOrEqualTo(input: string) {
20-
return semver.gte(await macOsVersion.value, clean(input))
20+
const version = await macOsVersion.value
21+
return semver.gte(clean(version), clean(input))
2122
}
2223

2324
/** @internal */
2425
export async function isMacOsSierra() {
25-
return process.platform === "darwin" && await isOsVersionGreaterThanOrEqualTo("10.12")
26-
}
26+
return process.platform === "darwin" && await isOsVersionGreaterThanOrEqualTo("10.12.0")
27+
}

0 commit comments

Comments
 (0)