fix(config): use json5 parser for json5 build configs#1578
Closed
black-snow wants to merge 1 commit intoelectron-userland:masterfrom
Closed
fix(config): use json5 parser for json5 build configs#1578black-snow wants to merge 1 commit intoelectron-userland:masterfrom
black-snow wants to merge 1 commit intoelectron-userland:masterfrom
Conversation
Use json5 parser to parse json5 build configs (i. e. files ending on "json5"). Json5 can have javascript-style comments whereas yaml does not. Thus we cannot use the yaml parser for json5.
|
@black-snow, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BurningEnlightenment, @Anmo and @stefanjudis to be potential reviewers. |
Contributor
Author
|
@develar Sadly I don't know how to correctly |
Contributor
|
Ignore CI errors — bintray issues. Thanks! I will merge soon (I will add typings for json5). |
Contributor
Author
|
Thanks for looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use json5 parser to parse json5 build configs (i. e. files ending on
"json5").
Json5 can have javascript-style comments whereas yaml does not. Thus we
cannot
use the yaml parser for json5.