Allow custom .p12 certificates#216
Allow custom .p12 certificates#216pauliusuza wants to merge 1 commit intoelectron-userland:masterfrom bdswiss:master
Conversation
|
By analyzing the blame information on this pull request, we identified @develar to be a potential reviewer |
|
@pauliusuza A means Authority? You have a good CA — only one certificate in the chain :) Maybe in the future we should allow to specify several (separated by comma in the CSA_LINK), but for now it is ok. |
|
Blocked on #208 and #218. PR can be accepted, but release version cannot be published. @pauliusuza Could you please
|
|
I use a digicert certificate for signing my app locally - works like a charm. When setting my build process up, I had to do this for the warning in the keychain to go away: https://www.digicert.com/code-signing/mac-verifying-code-signing-certificate.htm#remove_warning On the travis server, the error was a bit more cryptic You can notice the |
remove hardcoded apple.cer in favor of customizable options.csaLink (CSA_LINK)
|
@pauliusuza PR will be merged and new version will be published in a few hours. |
|
@develar amazing, thank you. |
|
@pauliusuza Thanks a lot! You save me a lot of time. Please confirm — do you sign OS X using non-Apple cert? Does it work? Also, I think we can import digicert by default, so, users will not have to do it explicitly. What do you think? |
This patch enables signing OSX apps with custom .p12 certificates issued by trusted CA.
Added: