fix: support asar in package.json's main property even when not kaging to asar during the build#759
Closed
wojtkowiak wants to merge 1 commit intoelectron-userland:masterfrom
wojtkowiak:master
Closed
fix: support asar in package.json's main property even when not kaging to asar during the build#759wojtkowiak wants to merge 1 commit intoelectron-userland:masterfrom wojtkowiak:master
main property even when not kaging to asar during the build#759wojtkowiak wants to merge 1 commit intoelectron-userland:masterfrom
wojtkowiak:master
Conversation
…kaging to asar during the build fix the case when the app is packaged to asar before the build process in this case there might be an asar archive specified in the `main` file path even if the asar options was set to false
|
@wojtkowiak, thanks for your PR! By analyzing the annotation information on this pull request, we identified @develar, @ha-D and @demetris-manikas to be potential reviewers |
Contributor
|
Binary files (like Thanks for pull request. |
Contributor
Author
|
@develar thanks for correcting 😄 and quick response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the case when the app is packaged to
.asarearlier than in the process of building with electron-builder.In my case I have the app split into 3 smaller asar archives for some modularity reasons. I have tried with
asar: falsebut it failed even though Electron normally supports it. You can provide any path in themainofpackage.jsone.g. it could besomePath/some.asar/evenMore/index.js.I did not create an issue because I went to fixing it immediately. If an issue needs to be filed first, let me know.
In the tests I have added
(custom asar)to distinguish it from usingasar: true- not sure if this naming is ok.