Skip to content

Conversation

@Stelios-Kourlis
Copy link
Contributor

  • Closes Deprecate ImageButton? #7466
  • I have followed the instructions in the PR template
  • I have ran ./scripts/check.sh and it has no fails
  • I have run cargo fmt and cargo clippy

Added the deprecated tag to ImageButton struct
Removed the WidgetType::ImageButton variant. ImageButton will use WidgetType::Button for its WidgetInfo

This is my first PR ever, please let me know if I did something wrong so I can change it

ImageButton  now uses WidgetType::Button instead
@Stelios-Kourlis Stelios-Kourlis requested a review from bircni August 29, 2025 18:21
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk added the egui label Sep 4, 2025
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Preview available at https://egui-pr-preview.github.io/pr/7483-deprecate-imagebutton
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk changed the title Deprecated ImageButton and removed WidgetType::ImageButton Deprecated ImageButton and removed WidgetType::ImageButton Sep 4, 2025
@emilk emilk merged commit 5fd4523 into emilk:main Sep 4, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate ImageButton?

4 participants