Return 0.0 if font not found in glyph_width instead of panic
#7559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
changed the title
0.0 if font not found in glyph_width instead of panic
|
Preview available at https://egui-pr-preview.github.io/pr/7559-lucasread-glyph-width-test |
emilk
approved these changes
Sep 23, 2025
podusowski
pushed a commit
to podusowski/egui
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glyph_widthin egui_commonmark #7548This reverts to the
glyph_widthbehaviour before #7431 - return 0.0 if font not found instead of panicing.The main use for this is when using
__run_test_ui, which doesn't register any fonts, any code using glyph_width would previously panic.