Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Conversation

@gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 28, 2024

Required for EIP-7702 implementation

@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (80ddf2f) to head (fa053cf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          26       26           
  Lines        3887     3887           
  Branches      404      404           
=======================================
  Hits         3631     3631           
  Misses        140      140           
  Partials      116      116           

@gumb0 gumb0 force-pushed the delegated_flag branch 2 times, most recently from f36f63b to 4f617bb Compare September 19, 2024 13:17
@gumb0 gumb0 marked this pull request as ready for review September 19, 2024 13:29
@gumb0 gumb0 requested review from chfast and pdobacz September 19, 2024 13:29
Copy link
Member

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (codewise)

@chfast
Copy link
Member

chfast commented Sep 19, 2024

Let me review the 7702 implementation first.

{
EVMC_STATIC = 1 /**< Static call mode. */
EVMC_STATIC = 1, /**< Static call mode. */
EVMC_DELEGATED = 2 /**< Delegated call mode (EIP-7702). Valid since Prague. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider "designated" name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? "Delegation designation" in the EIP refers to 0xef0100 || address string in account's code. Here the flag is about execution mode.

@chfast chfast merged commit 11ff1eb into master Feb 7, 2025
19 checks passed
@chfast chfast deleted the delegated_flag branch February 7, 2025 08:55
chfast added a commit to ipsilon/evmone that referenced this pull request Feb 13, 2025
Implement [EIP-7702: Set EOA account
code](https://eips.ethereum.org/EIPS/eip-7702). This EIP adds new
transaction type _set-code_ that permanently sets the code delegation
for an EOA.

Requires new EVMC flag: ipsilon/evmc#720.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants