-
Notifications
You must be signed in to change notification settings - Fork 325
Add EVMC_DELEGATED flag #720
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 26 26
Lines 3887 3887
Branches 404 404
=======================================
Hits 3631 3631
Misses 140 140
Partials 116 116 |
f36f63b to
4f617bb
Compare
pdobacz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (codewise)
4f617bb to
08b8279
Compare
|
Let me review the 7702 implementation first. |
| { | ||
| EVMC_STATIC = 1 /**< Static call mode. */ | ||
| EVMC_STATIC = 1, /**< Static call mode. */ | ||
| EVMC_DELEGATED = 2 /**< Delegated call mode (EIP-7702). Valid since Prague. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider "designated" name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? "Delegation designation" in the EIP refers to 0xef0100 || address string in account's code. Here the flag is about execution mode.
37b0084 to
fa053cf
Compare
Implement [EIP-7702: Set EOA account code](https://eips.ethereum.org/EIPS/eip-7702). This EIP adds new transaction type _set-code_ that permanently sets the code delegation for an EOA. Requires new EVMC flag: ipsilon/evmc#720.
Required for EIP-7702 implementation