create new variable scope for each test run to avoid polluting the default settings with overrides

pk910 · pk910 · commit 91da5cdecb87 · 2024-09-12T22:45:18.000+02:00
diff --git a/pkg/coordinator/test/test.go b/pkg/coordinator/test/test.go
@@ -7,6 +7,7 @@ import (
 
 	"github.com/ethpandaops/assertoor/pkg/coordinator/scheduler"
 	"github.com/ethpandaops/assertoor/pkg/coordinator/types"
+	"github.com/ethpandaops/assertoor/pkg/coordinator/vars"
 	"github.com/sirupsen/logrus"
 )
 
@@ -37,7 +38,7 @@ func CreateTest(runID uint64, descriptor types.TestDescriptor, logger logrus.Fie
 	}
 
 	// set test variables
-	test.variables = descriptor.Vars()
+	test.variables = vars.NewVariables(descriptor.Vars())
 
 	// parse tasks
 	test.taskScheduler = scheduler.NewTaskScheduler(test.logger, services, test.variables)

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import (`
`7`	`7`
`8`	`8`	`"github.com/ethpandaops/assertoor/pkg/coordinator/scheduler"`
`9`	`9`	`"github.com/ethpandaops/assertoor/pkg/coordinator/types"`
	`10`	`+ "github.com/ethpandaops/assertoor/pkg/coordinator/vars"`
`10`	`11`	`"github.com/sirupsen/logrus"`
`11`	`12`	`)`
`12`	`13`
`@@ -37,7 +38,7 @@ func CreateTest(runID uint64, descriptor types.TestDescriptor, logger logrus.Fie`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`// set test variables`
`40`		`- test.variables = descriptor.Vars()`
	`41`	`+ test.variables = vars.NewVariables(descriptor.Vars())`
`41`	`42`
`42`	`43`	`// parse tasks`
`43`	`44`	`test.taskScheduler = scheduler.NewTaskScheduler(test.logger, services, test.variables)`