Skip to content

Commit dbfcb63

Browse files
committed
fix panic when schedule config is nil
1 parent c072f3d commit dbfcb63

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pkg/coordinator/testrunner.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,15 +210,16 @@ func (c *TestRunner) RunTestScheduler(ctx context.Context) {
210210
err2 = errval
211211
}
212212

213-
c.coordinator.Logger().WithError(err2).Panicf("uncaught panic in TestRunner.RunTestScheduler: %v, stack: %v", err, string(debug.Stack()))
213+
c.coordinator.Logger().Panicf("uncaught panic in TestRunner.RunTestScheduler: %v, stack: %v", err2, string(debug.Stack()))
214214
}
215215
}()
216216

217217
// startup scheduler
218218
for _, testDescr := range c.getStartupTests() {
219219
testConfig := testDescr.Config()
220+
skipQueue := testConfig.Schedule != nil && testConfig.Schedule.SkipQueue
220221

221-
_, err := c.ScheduleTest(testDescr, nil, false, testConfig.Schedule.SkipQueue)
222+
_, err := c.ScheduleTest(testDescr, nil, false, skipQueue)
222223
if err != nil {
223224
c.coordinator.Logger().Errorf("could not schedule startup test execution for %v (%v): %v", testDescr.ID(), testConfig.Name, err)
224225
}
@@ -241,8 +242,9 @@ func (c *TestRunner) RunTestScheduler(ctx context.Context) {
241242

242243
for _, testDescr := range c.getCronTests(cronTime) {
243244
testConfig := testDescr.Config()
245+
skipQueue := testConfig.Schedule != nil && testConfig.Schedule.SkipQueue
244246

245-
_, err := c.ScheduleTest(testDescr, nil, false, testConfig.Schedule.SkipQueue)
247+
_, err := c.ScheduleTest(testDescr, nil, false, skipQueue)
246248
if err != nil {
247249
c.coordinator.Logger().Errorf("could not schedule cron test execution for %v (%v): %v", testDescr.ID(), testConfig.Name, err)
248250
}

0 commit comments

Comments
 (0)