Registration tokens can become stale. (#224)

davidkarlsen · web-flow · commit 5d83b943ed8b · 2021-04-06T18:28:13.000+02:00
diff --git a/controllers/githubactionrunner_controller.go b/controllers/githubactionrunner_controller.go
@@ -226,7 +226,8 @@ func (r *GithubActionRunnerReconciler) createOrUpdateRegistrationTokenSecret(ctx
 		return err
 	}
 
-	expired := time.Unix(epoch, 0).Before(time.Now().Add(-5 * time.Minute))
+	// allow for 5 minute clock-skew
+	expired := time.Now().Add(5 * time.Minute).After(time.Unix(epoch, 0))
 	if expired {
 		logger.Info("Registration token expired, updating")
 		return r.updateRegistrationToken(ctx, instance, secret)

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,8 @@ func (r *GithubActionRunnerReconciler) createOrUpdateRegistrationTokenSecret(ctx`
`226`	`226`	`return err`
`227`	`227`	`}`
`228`	`228`
`229`		`- expired := time.Unix(epoch, 0).Before(time.Now().Add(-5 * time.Minute))`
	`229`	`+ // allow for 5 minute clock-skew`
	`230`	`+ expired := time.Now().Add(5 * time.Minute).After(time.Unix(epoch, 0))`
`230`	`231`	`if expired {`
`231`	`232`	`logger.Info("Registration token expired, updating")`
`232`	`233`	`return r.updateRegistrationToken(ctx, instance, secret)`