Skip to content

Allow NumPy v1 in installation requirements#956

Merged
honnibal merged 1 commit intoexplosion:v8.3.xfrom
BLKSerene:v8.3.x
Jul 11, 2025
Merged

Allow NumPy v1 in installation requirements#956
honnibal merged 1 commit intoexplosion:v8.3.xfrom
BLKSerene:v8.3.x

Conversation

@BLKSerene
Copy link
Contributor

Description

Similar to explosion/spacy-pkuseg#18, this PR updates the version pin to allow thinc to be used with NumPy v1 to ease compatibility issues with other 3rd-party packages requiring NumPy 1.x.

Types of change

Dependency change.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@BLKSerene
Copy link
Contributor Author

Gentle ping, @honnibal.

@honnibal
Copy link
Member

Thanks! Sorry I messed this up before.

@honnibal honnibal merged commit 7cc395c into explosion:v8.3.x Jul 11, 2025
@BLKSerene
Copy link
Contributor Author

@honnibal, could you please release a new version to reflect this dependency change? It seems that the release of thinc 8.3.7 was not successful.

@honnibal
Copy link
Member

honnibal commented Nov 6, 2025

Sorry about the delay on this, I didn't realise it didn't upload. We had problems with our PyPi account being at its storage limit which took some time to resolve. I then lost track of the status of this and thought it was all complete. A new version is up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants