Skip to content

Commit 68efca9

Browse files
authored
Merge pull request #1833 from coado/250829098.0.0-stable
Cherry picking fixes to `create-tag` workflow and description improvements
2 parents 40dd6c6 + 0343f22 commit 68efca9

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/workflows/create-tag.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212
- dry-run
1313
hermes-version:
1414
required: true
15-
description: The Hermes version to use for this tag
15+
description: The Hermes version to use for this tag. It will be used to create the tag name of the form hermes-v${ hermes-version }
1616
type: string
1717
workflow_call:
1818
inputs:
@@ -22,7 +22,7 @@ on:
2222
type: string
2323
hermes-version:
2424
required: true
25-
description: The Hermes version to use for this tag
25+
description: The Hermes version to use for this tag. It will be used to create the tag name of the form hermes-v${ hermes-version }
2626
type: string
2727

2828
jobs:

.github/workflows/rn-build-hermes.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
if: github.repository == 'facebook/hermes'
2323
outputs:
2424
RELEASE_TYPE: ${{ steps.set_release_type.outputs.RELEASE_TYPE }}
25+
HERMES_VERSION: ${{ steps.generate_version.outputs.HERMES_VERSION }}
2526
env:
2627
EVENT_NAME: ${{ github.event_name }}
2728
REF: ${{ github.ref }}
@@ -77,7 +78,11 @@ jobs:
7778
release-type: ${{ needs.set_release_type.outputs.RELEASE_TYPE }}
7879
create-tag:
7980
uses: ./.github/workflows/create-tag.yml
80-
needs: publish
81+
needs:
82+
[
83+
publish,
84+
set_release_type,
85+
]
8186
with:
8287
release-type: ${{ needs.set_release_type.outputs.RELEASE_TYPE }}
8388
hermes-version: ${{ needs.set_release_type.outputs.HERMES_VERSION }}

0 commit comments

Comments
 (0)