feat: split some "jest-snapshot" utility functions to its own package "@jest/snapshot-utils" #15095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/snapshot-utils"
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
connectdotz
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #15036.
Changes include:
Moved the specific functions mentioned in the issue, along with any supporting functions and those sharing the same locally defined private constants. This targeted approach minimizes changes and avoids potential circular references, rather than moving the entire utils.ts file.
Fixed a few end-to-end (e2e) unit tests that caused
yarn testto fail during development. The failures were specifically related to the generation of empty .watchmanconfig files in these tests. With watchman version2024.05.06.00on mac, I encountered JSON parsing errors when the config file was blank (rather than containing{}or[]). This fix is limited to the occurrences encountered to keep the scope of changes manageable.Test plan
should not break existing tests