Skip to content

Commit 1d4d1d4

Browse files
coadofacebook-github-bot
coado
authored and
facebook-github-bot
committed
Exclude symbols with DO_NOT_USE from the public C++ API snapshot (#56346)
Summary: Excludes all symbols and members that consists of `DO_NOT_USE`, like - findComponentViewWithTag_DO_NOT_USE_DEPRECATED - propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN - componentViewName_DO_NOT_USE_THIS_IS_BROKEN - ensurePlaceholderIfEmpty_DO_NOT_USE Changelog: [Internal] Reviewed By: cortinico Differential Revision: D99834673
1 parent a58ddb1 commit 1d4d1d4

File tree

7 files changed

+1
-34
lines changed

7 files changed

+1
-34
lines changed

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,6 @@ double facebook::react::getCPUTimeNanos();
827827
double facebook::react::interpolate(double inputValue, double inputMin, double inputMax, double outputMin, double outputMax, std::string_view extrapolateLeft, std::string_view extrapolateRight);
828828
double facebook::react::round(double value) noexcept;
829829
facebook::jsi::Value facebook::react::createPromiseAsJSIValue(facebook::jsi::Runtime& rt, facebook::react::PromiseSetupFunctionType&& func);
830-
facebook::react::AttributedString facebook::react::ensurePlaceholderIfEmpty_DO_NOT_USE(const facebook::react::AttributedString& attributedString);
831830
facebook::react::Color facebook::react::hostPlatformColorFromComponents(facebook::react::ColorComponents components);
832831
facebook::react::Color facebook::react::hostPlatformColorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
833832
facebook::react::ColorComponents facebook::react::colorComponentsFromColor(facebook::react::SharedColor color);
@@ -1998,7 +1997,6 @@ class facebook::react::ComponentDescriptorRegistry {
19981997
public bool hasComponentDescriptorAt(facebook::react::ComponentHandle componentHandle) const;
19991998
public const facebook::react::ComponentDescriptor& at(const std::string& componentName) const;
20001999
public const facebook::react::ComponentDescriptor& at(facebook::react::ComponentHandle componentHandle) const;
2001-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle componentHandle) const;
20022000
public facebook::react::ComponentDescriptor::Shared getFallbackComponentDescriptor() const;
20032001
public using Shared = std::shared_ptr<const facebook::react::ComponentDescriptorRegistry>;
20042002
public void setFallbackComponentDescriptor(const facebook::react::SharedComponentDescriptor& descriptor);
@@ -4458,7 +4456,6 @@ class facebook::react::SafeAreaViewState {
44584456

44594457
class facebook::react::Scheduler : public facebook::react::UIManagerDelegate {
44604458
public Scheduler(const facebook::react::SchedulerToolbox& schedulerToolbox, facebook::react::UIManagerAnimationDelegate* animationDelegate, facebook::react::SchedulerDelegate* delegate);
4461-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle handle) const;
44624459
public facebook::react::SchedulerDelegate* getDelegate() const;
44634460
public std::shared_ptr<const facebook::react::ContextContainer> getContextContainer() const;
44644461
public std::shared_ptr<facebook::react::UIManager> getUIManager() const;

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,6 @@ double facebook::react::getCPUTimeNanos();
827827
double facebook::react::interpolate(double inputValue, double inputMin, double inputMax, double outputMin, double outputMax, std::string_view extrapolateLeft, std::string_view extrapolateRight);
828828
double facebook::react::round(double value) noexcept;
829829
facebook::jsi::Value facebook::react::createPromiseAsJSIValue(facebook::jsi::Runtime& rt, facebook::react::PromiseSetupFunctionType&& func);
830-
facebook::react::AttributedString facebook::react::ensurePlaceholderIfEmpty_DO_NOT_USE(const facebook::react::AttributedString& attributedString);
831830
facebook::react::Color facebook::react::hostPlatformColorFromComponents(facebook::react::ColorComponents components);
832831
facebook::react::Color facebook::react::hostPlatformColorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
833832
facebook::react::ColorComponents facebook::react::colorComponentsFromColor(facebook::react::SharedColor color);
@@ -1996,7 +1995,6 @@ class facebook::react::ComponentDescriptorRegistry {
19961995
public bool hasComponentDescriptorAt(facebook::react::ComponentHandle componentHandle) const;
19971996
public const facebook::react::ComponentDescriptor& at(const std::string& componentName) const;
19981997
public const facebook::react::ComponentDescriptor& at(facebook::react::ComponentHandle componentHandle) const;
1999-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle componentHandle) const;
20001998
public facebook::react::ComponentDescriptor::Shared getFallbackComponentDescriptor() const;
20011999
public using Shared = std::shared_ptr<const facebook::react::ComponentDescriptorRegistry>;
20022000
public void setFallbackComponentDescriptor(const facebook::react::SharedComponentDescriptor& descriptor);
@@ -4455,7 +4453,6 @@ class facebook::react::SafeAreaViewState {
44554453

44564454
class facebook::react::Scheduler : public facebook::react::UIManagerDelegate {
44574455
public Scheduler(const facebook::react::SchedulerToolbox& schedulerToolbox, facebook::react::UIManagerAnimationDelegate* animationDelegate, facebook::react::SchedulerDelegate* delegate);
4458-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle handle) const;
44594456
public facebook::react::SchedulerDelegate* getDelegate() const;
44604457
public std::shared_ptr<const facebook::react::ContextContainer> getContextContainer() const;
44614458
public std::shared_ptr<facebook::react::UIManager> getUIManager() const;

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ category RCTSurfacePresenter(Surface) {
286286
public @property (assign, readonly) RCTMountingManager* mountingManager;
287287
public @property (assign, readonly) RCTScheduler* scheduler;
288288
public virtual _Nullable RCTFabricSurface* surfaceForRootTag:(ReactTag rootTag);
289-
public virtual _Nullable UIView* findComponentViewWithTag_DO_NOT_USE_DEPRECATED:(NSInteger tag);
290289
public virtual id<RCTSurfaceProtocol> createFabricSurfaceForModuleName:initialProperties:(NSString* moduleName, NSDictionary* initialProperties);
291290
public virtual void addObserver:(id<RCTSurfacePresenterObserver> observer);
292291
public virtual void registerSurface:(RCTFabricSurface* surface);
@@ -302,15 +301,13 @@ category UIImage(React) {
302301
}
303302

304303
category UIView(ComponentViewProtocol) {
305-
public virtual _Nullable NSSet<NSString*>* propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN();
306304
public virtual facebook::react::Props::Shared props();
307305
public virtual static std::vector<facebook::react::ComponentDescriptorProvider> supplementalComponentDescriptorProviders();
308306
public virtual void finalizeUpdates:(RNComponentViewUpdateMask updateMask);
309307
public virtual void invalidate();
310308
public virtual void mountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
311309
public virtual void prepareForRecycle();
312310
public virtual void setIsJSResponder:(BOOL isJSResponder);
313-
public virtual void setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(_Nullable NSSet<NSString*>* props);
314311
public virtual void unmountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
315312
public virtual void updateClippedSubviewsWithClipRect:relativeToView:(CGRect clipRect, UIView* clipView);
316313
public virtual void updateEventEmitter:(const facebook::react::EventEmitter::Shared& eventEmitter);
@@ -1929,7 +1926,6 @@ interface RCTSafeAreaViewManager : public RCTViewManager {
19291926
interface RCTScheduler : public NSObject {
19301927
public @property (assign, readonly) const std::shared_ptr<facebook::react::UIManager> uiManager;
19311928
public @property (weak) id<RCTSchedulerDelegate> delegate;
1932-
public virtual const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN:(facebook::react::ComponentHandle handle);
19331929
public virtual instancetype initWithToolbox:(facebook::react::SchedulerToolbox toolbox);
19341930
public virtual void addEventListener:(const std::shared_ptr<facebook::react::EventListener>& listener);
19351931
public virtual void animationTick();
@@ -2505,7 +2501,6 @@ interface RCTViewComponentView : public UIView <RCTComponentViewProtocol, RCTTou
25052501
public @property (strong, readonly) NSObject* accessibilityElement;
25062502
public virtual BOOL wantsToCooptLabel();
25072503
public virtual NSString* accessibilityLabelForCoopting();
2508-
public virtual NSString* componentViewName_DO_NOT_USE_THIS_IS_BROKEN();
25092504
public virtual UIView* betterHitTest:withEvent:(CGPoint point, UIEvent* event);
25102505
public virtual void finalizeUpdates:(RNComponentViewUpdateMask updateMask);
25112506
public virtual void prepareForRecycle();
@@ -3075,7 +3070,6 @@ protocol RCTComponentViewFactoryComponentProvider : public NSObject {
30753070

30763071
protocol RCTComponentViewProtocol : public NSObject {
30773072
public virtual BOOL isJSResponder();
3078-
public virtual _Nullable NSSet<NSString*>* propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN();
30793073
public virtual facebook::react::Props::Shared props();
30803074
public virtual static facebook::react::ComponentDescriptorProvider componentDescriptorProvider();
30813075
public virtual static std::vector<facebook::react::ComponentDescriptorProvider> supplementalComponentDescriptorProviders();
@@ -3085,7 +3079,6 @@ protocol RCTComponentViewProtocol : public NSObject {
30853079
public virtual void mountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
30863080
public virtual void prepareForRecycle();
30873081
public virtual void setIsJSResponder:(BOOL isJSResponder);
3088-
public virtual void setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(_Nullable NSSet<NSString*>* props);
30893082
public virtual void unmountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
30903083
public virtual void updateEventEmitter:(const facebook::react::EventEmitter::Shared& eventEmitter);
30913084
public virtual void updateLayoutMetrics:oldLayoutMetrics:(const facebook::react::LayoutMetrics& layoutMetrics, const facebook::react::LayoutMetrics& oldLayoutMetrics);
@@ -3436,7 +3429,6 @@ protocol RCTSurfacePresenterObserver : public NSObject {
34363429
}
34373430

34383431
protocol RCTSurfacePresenterStub : public NSObject {
3439-
public virtual _Nullable UIView* findComponentViewWithTag_DO_NOT_USE_DEPRECATED:(NSInteger tag);
34403432
public virtual id<RCTSurfaceProtocol> createFabricSurfaceForModuleName:initialProperties:(NSString* moduleName, NSDictionary* initialProperties);
34413433
public virtual void addObserver:(id<RCTSurfacePresenterObserver> observer);
34423434
public virtual void removeObserver:(id<RCTSurfacePresenterObserver> observer);
@@ -4093,7 +4085,6 @@ double facebook::react::getCPUTimeNanos();
40934085
double facebook::react::interpolate(double inputValue, double inputMin, double inputMax, double outputMin, double outputMax, std::string_view extrapolateLeft, std::string_view extrapolateRight);
40944086
double facebook::react::round(double value) noexcept;
40954087
facebook::jsi::Value facebook::react::createPromiseAsJSIValue(facebook::jsi::Runtime& rt, facebook::react::PromiseSetupFunctionType&& func);
4096-
facebook::react::AttributedString facebook::react::ensurePlaceholderIfEmpty_DO_NOT_USE(const facebook::react::AttributedString& attributedString);
40974088
facebook::react::Color facebook::react::hostPlatformColorFromComponents(facebook::react::ColorComponents components);
40984089
facebook::react::Color facebook::react::hostPlatformColorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
40994090
facebook::react::ColorComponents facebook::react::colorComponentsFromColor(facebook::react::SharedColor color);
@@ -4977,7 +4968,6 @@ class facebook::react::ComponentDescriptorRegistry {
49774968
public bool hasComponentDescriptorAt(facebook::react::ComponentHandle componentHandle) const;
49784969
public const facebook::react::ComponentDescriptor& at(const std::string& componentName) const;
49794970
public const facebook::react::ComponentDescriptor& at(facebook::react::ComponentHandle componentHandle) const;
4980-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle componentHandle) const;
49814971
public facebook::react::ComponentDescriptor::Shared getFallbackComponentDescriptor() const;
49824972
public using Shared = std::shared_ptr<const facebook::react::ComponentDescriptorRegistry>;
49834973
public void setFallbackComponentDescriptor(const facebook::react::SharedComponentDescriptor& descriptor);
@@ -7095,7 +7085,6 @@ class facebook::react::SafeAreaViewState {
70957085

70967086
class facebook::react::Scheduler : public facebook::react::UIManagerDelegate {
70977087
public Scheduler(const facebook::react::SchedulerToolbox& schedulerToolbox, facebook::react::UIManagerAnimationDelegate* animationDelegate, facebook::react::SchedulerDelegate* delegate);
7098-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle handle) const;
70997088
public facebook::react::SchedulerDelegate* getDelegate() const;
71007089
public std::shared_ptr<const facebook::react::ContextContainer> getContextContainer() const;
71017090
public std::shared_ptr<facebook::react::UIManager> getUIManager() const;

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ category RCTSurfacePresenter(Surface) {
286286
public @property (assign, readonly) RCTMountingManager* mountingManager;
287287
public @property (assign, readonly) RCTScheduler* scheduler;
288288
public virtual _Nullable RCTFabricSurface* surfaceForRootTag:(ReactTag rootTag);
289-
public virtual _Nullable UIView* findComponentViewWithTag_DO_NOT_USE_DEPRECATED:(NSInteger tag);
290289
public virtual id<RCTSurfaceProtocol> createFabricSurfaceForModuleName:initialProperties:(NSString* moduleName, NSDictionary* initialProperties);
291290
public virtual void addObserver:(id<RCTSurfacePresenterObserver> observer);
292291
public virtual void registerSurface:(RCTFabricSurface* surface);
@@ -302,15 +301,13 @@ category UIImage(React) {
302301
}
303302

304303
category UIView(ComponentViewProtocol) {
305-
public virtual _Nullable NSSet<NSString*>* propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN();
306304
public virtual facebook::react::Props::Shared props();
307305
public virtual static std::vector<facebook::react::ComponentDescriptorProvider> supplementalComponentDescriptorProviders();
308306
public virtual void finalizeUpdates:(RNComponentViewUpdateMask updateMask);
309307
public virtual void invalidate();
310308
public virtual void mountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
311309
public virtual void prepareForRecycle();
312310
public virtual void setIsJSResponder:(BOOL isJSResponder);
313-
public virtual void setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(_Nullable NSSet<NSString*>* props);
314311
public virtual void unmountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
315312
public virtual void updateClippedSubviewsWithClipRect:relativeToView:(CGRect clipRect, UIView* clipView);
316313
public virtual void updateEventEmitter:(const facebook::react::EventEmitter::Shared& eventEmitter);
@@ -1929,7 +1926,6 @@ interface RCTSafeAreaViewManager : public RCTViewManager {
19291926
interface RCTScheduler : public NSObject {
19301927
public @property (assign, readonly) const std::shared_ptr<facebook::react::UIManager> uiManager;
19311928
public @property (weak) id<RCTSchedulerDelegate> delegate;
1932-
public virtual const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN:(facebook::react::ComponentHandle handle);
19331929
public virtual instancetype initWithToolbox:(facebook::react::SchedulerToolbox toolbox);
19341930
public virtual void addEventListener:(const std::shared_ptr<facebook::react::EventListener>& listener);
19351931
public virtual void animationTick();
@@ -2505,7 +2501,6 @@ interface RCTViewComponentView : public UIView <RCTComponentViewProtocol, RCTTou
25052501
public @property (strong, readonly) NSObject* accessibilityElement;
25062502
public virtual BOOL wantsToCooptLabel();
25072503
public virtual NSString* accessibilityLabelForCoopting();
2508-
public virtual NSString* componentViewName_DO_NOT_USE_THIS_IS_BROKEN();
25092504
public virtual UIView* betterHitTest:withEvent:(CGPoint point, UIEvent* event);
25102505
public virtual void finalizeUpdates:(RNComponentViewUpdateMask updateMask);
25112506
public virtual void prepareForRecycle();
@@ -3075,7 +3070,6 @@ protocol RCTComponentViewFactoryComponentProvider : public NSObject {
30753070

30763071
protocol RCTComponentViewProtocol : public NSObject {
30773072
public virtual BOOL isJSResponder();
3078-
public virtual _Nullable NSSet<NSString*>* propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN();
30793073
public virtual facebook::react::Props::Shared props();
30803074
public virtual static facebook::react::ComponentDescriptorProvider componentDescriptorProvider();
30813075
public virtual static std::vector<facebook::react::ComponentDescriptorProvider> supplementalComponentDescriptorProviders();
@@ -3085,7 +3079,6 @@ protocol RCTComponentViewProtocol : public NSObject {
30853079
public virtual void mountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
30863080
public virtual void prepareForRecycle();
30873081
public virtual void setIsJSResponder:(BOOL isJSResponder);
3088-
public virtual void setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(_Nullable NSSet<NSString*>* props);
30893082
public virtual void unmountChildComponentView:index:(UIView<RCTComponentViewProtocol>* childComponentView, NSInteger index);
30903083
public virtual void updateEventEmitter:(const facebook::react::EventEmitter::Shared& eventEmitter);
30913084
public virtual void updateLayoutMetrics:oldLayoutMetrics:(const facebook::react::LayoutMetrics& layoutMetrics, const facebook::react::LayoutMetrics& oldLayoutMetrics);
@@ -3436,7 +3429,6 @@ protocol RCTSurfacePresenterObserver : public NSObject {
34363429
}
34373430

34383431
protocol RCTSurfacePresenterStub : public NSObject {
3439-
public virtual _Nullable UIView* findComponentViewWithTag_DO_NOT_USE_DEPRECATED:(NSInteger tag);
34403432
public virtual id<RCTSurfaceProtocol> createFabricSurfaceForModuleName:initialProperties:(NSString* moduleName, NSDictionary* initialProperties);
34413433
public virtual void addObserver:(id<RCTSurfacePresenterObserver> observer);
34423434
public virtual void removeObserver:(id<RCTSurfacePresenterObserver> observer);
@@ -4093,7 +4085,6 @@ double facebook::react::getCPUTimeNanos();
40934085
double facebook::react::interpolate(double inputValue, double inputMin, double inputMax, double outputMin, double outputMax, std::string_view extrapolateLeft, std::string_view extrapolateRight);
40944086
double facebook::react::round(double value) noexcept;
40954087
facebook::jsi::Value facebook::react::createPromiseAsJSIValue(facebook::jsi::Runtime& rt, facebook::react::PromiseSetupFunctionType&& func);
4096-
facebook::react::AttributedString facebook::react::ensurePlaceholderIfEmpty_DO_NOT_USE(const facebook::react::AttributedString& attributedString);
40974088
facebook::react::Color facebook::react::hostPlatformColorFromComponents(facebook::react::ColorComponents components);
40984089
facebook::react::Color facebook::react::hostPlatformColorFromRGBA(uint8_t r, uint8_t g, uint8_t b, uint8_t a);
40994090
facebook::react::ColorComponents facebook::react::colorComponentsFromColor(facebook::react::SharedColor color);
@@ -4975,7 +4966,6 @@ class facebook::react::ComponentDescriptorRegistry {
49754966
public bool hasComponentDescriptorAt(facebook::react::ComponentHandle componentHandle) const;
49764967
public const facebook::react::ComponentDescriptor& at(const std::string& componentName) const;
49774968
public const facebook::react::ComponentDescriptor& at(facebook::react::ComponentHandle componentHandle) const;
4978-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle componentHandle) const;
49794969
public facebook::react::ComponentDescriptor::Shared getFallbackComponentDescriptor() const;
49804970
public using Shared = std::shared_ptr<const facebook::react::ComponentDescriptorRegistry>;
49814971
public void setFallbackComponentDescriptor(const facebook::react::SharedComponentDescriptor& descriptor);
@@ -7092,7 +7082,6 @@ class facebook::react::SafeAreaViewState {
70927082

70937083
class facebook::react::Scheduler : public facebook::react::UIManagerDelegate {
70947084
public Scheduler(const facebook::react::SchedulerToolbox& schedulerToolbox, facebook::react::UIManagerAnimationDelegate* animationDelegate, facebook::react::SchedulerDelegate* delegate);
7095-
public const facebook::react::ComponentDescriptor* findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN(facebook::react::ComponentHandle handle) const;
70967085
public facebook::react::SchedulerDelegate* getDelegate() const;
70977086
public std::shared_ptr<const facebook::react::ContextContainer> getContextContainer() const;
70987087
public std::shared_ptr<facebook::react::UIManager> getUIManager() const;

0 commit comments

Comments
 (0)