Skip to content

Commit 2f71270

Browse files
sebbargfacebook-github-bot
authored andcommitted
Run packager.sh using '.' instead of 'source'.
Summary: 'source' is not available in all shells on Linux (e.g. dash) and will silently fail launchPackager.command when called from runAndroid.js. react-native run-android will thus silently fail to start the developement server ('JS server'). What existing problem does the pull request solve? When running "react-native run-android" on the below reasonably vanilla Ubuntu system, the development server / packager script fails to start. It fails because sh defaults to dash (not bash) which doesn't know the command 'source'. dot (.) does the same as source, but works in all shells. $ uname -a Linux dallas 4.8.0-52-generic #55~16.04.1-Ubuntu SMP Fri Apr 28 14:36:29 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux $ which sh /bin/sh $ readlink -f /bin/sh /bin/dash react-native-cli: 2.0.1 react-native: 0.44.0 $ ps aux | grep packager (nothing) ps aux | grep packager sh /home/xxx/code/react-native/AwesomeProject/node_modules/react-native/packager/launchPackager.command node /home/xxx/code/react-native/AwesomeProject/node_modules/react-native/packager/../local-cli/cli.js start Closes #14040 Differential Revision: D5096298 Pulled By: hramos fbshipit-source-id: 88466e802c9bc4358840391edb37e153f0a6b1f7
1 parent 225c4c0 commit 2f71270

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packager/launchPackager.command

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ clear
1313

1414
THIS_DIR=$(dirname "$0")
1515
pushd "$THIS_DIR/.."
16-
source packager/packager.sh
16+
. packager/packager.sh
1717
popd
1818

1919
echo "Process terminated. Press <enter> to close the window"

0 commit comments

Comments
 (0)