Fix bitmap reuse race condition in FrameTimingsObserver (#55745)

Summary:
Pull Request resolved: #55745

The shared `bitmapBuffer` could be overwritten by a new `PixelCopy` request on the main thread while a previous frame's encoding coroutine was still reading from it. Each frame now gets its own bitmap, recycled after encoding.

NOTE: This will come at a slight perf cost (allocating extra new bitmaps in memory), for the tradeoff of correctness.

Changelog: [Internal]

Reviewed By: rubennorte

Differential Revision: D94368260

fbshipit-source-id: f89f6f4cdd34278ed91d4a673af343999550d919

Author: huntie

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/FrameTimingsObserver.kt

@@ -31,7 +31,6 @@ internal class FrameTimingsObserver(
 
   private val mainHandler = Handler(Looper.getMainLooper())
   private var frameCounter: Int = 0
-  private var bitmapBuffer: Bitmap? = null
   private var isStarted: Boolean = false
 
   @Volatile private var currentWindow: Window? = null
@@ -61,9 +60,6 @@ internal class FrameTimingsObserver(
 
     currentWindow?.removeOnFrameMetricsAvailableListener(frameMetricsListener)
     mainHandler.removeCallbacksAndMessages(null)
-
-    bitmapBuffer?.recycle()
-    bitmapBuffer = null
   }
 
   fun setCurrentWindow(window: Window?) {
@@ -124,14 +120,7 @@ internal class FrameTimingsObserver(
     val decorView = window.decorView
     val width = decorView.width
     val height = decorView.height
-
-    // Reuse bitmap if dimensions haven't changed
-    val bitmap =
-        bitmapBuffer?.takeIf { it.width == width && it.height == height }
-            ?: run {
-              bitmapBuffer?.recycle()
-              Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888).also { bitmapBuffer = it }
-            }
+    val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888)
 
     PixelCopy.request(
         window,
@@ -142,6 +131,7 @@ internal class FrameTimingsObserver(
               callback(encodeScreenshot(window, bitmap, width, height))
             }
           } else {
+            bitmap.recycle()
             callback(null)
           }
         },
@@ -169,6 +159,7 @@ internal class FrameTimingsObserver(
       null
     } finally {
       scaledBitmap?.recycle()
+      bitmap.recycle()
     }
   }