Increase frame capture quality, apply scaling after DPI normalization

Summary: Changelog: [Internal]

Differential Revision: D94256691

Author: huntie

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/FrameTimingsObserver.kt

@@ -118,16 +118,12 @@ internal class FrameTimingsObserver(
 
         // Reuse bitmap if dimensions haven't changed
         val bitmap =
-            bitmapBuffer?.let {
-              if (it.width == width && it.height == height) {
-                it
-              } else {
-                it.recycle()
-                null
-              }
-            }
-                ?: Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888).also {
-                  bitmapBuffer = it
+            bitmapBuffer?.takeIf { it.width == width && it.height == height }
+                ?: run {
+                  bitmapBuffer?.recycle()
+                  Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888).also {
+                    bitmapBuffer = it
+                  }
                 }
 
         // Suspend for PixelCopy callback
@@ -148,17 +144,17 @@ internal class FrameTimingsObserver(
         withContext(Dispatchers.Default) {
           var scaledBitmap: Bitmap? = null
           try {
-            val scaleFactor = 0.25f
-            val scaledWidth = (width * scaleFactor).toInt()
-            val scaledHeight = (height * scaleFactor).toInt()
+            val density = window.context.resources.displayMetrics.density
+            val scaledWidth = (width / density * SCREENSHOT_SCALE_FACTOR).toInt()
+            val scaledHeight = (height / density * SCREENSHOT_SCALE_FACTOR).toInt()
             scaledBitmap = Bitmap.createScaledBitmap(bitmap, scaledWidth, scaledHeight, true)
 
             val compressFormat =
                 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) Bitmap.CompressFormat.WEBP_LOSSY
                 else Bitmap.CompressFormat.WEBP
 
             ByteArrayOutputStream().use { outputStream ->
-              scaledBitmap.compress(compressFormat, 0, outputStream)
+              scaledBitmap.compress(compressFormat, SCREENSHOT_QUALITY, outputStream)
               Base64.encodeToString(outputStream.toByteArray(), Base64.NO_WRAP)
             }
           } catch (e: Exception) {
@@ -168,4 +164,9 @@ internal class FrameTimingsObserver(
           }
         }
       }
+
+  companion object {
+    private const val SCREENSHOT_SCALE_FACTOR = 0.75f
+    private const val SCREENSHOT_QUALITY = 80
+  }
 }