Fix BlobProvider not working in newarch (#56369)#56369
Closed
javache wants to merge 2 commits intofacebook:mainfrom
Closed
Fix BlobProvider not working in newarch (#56369)#56369javache wants to merge 2 commits intofacebook:mainfrom
javache wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
…acebook#56272) Summary: BlobCollector::nativeInstall received a raw jlong pointer to jsi::Runtime from Java and cast it directly, with no thread safety. Migrated BlobModule to implement TurboModuleWithJSIBindings, which provides a safe getBindingsInstaller() callback guaranteed to run on the JS thread during module initialization. Removed the unsafe raw pointer path. Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D98712509
Summary: Blob images in RNTester work Changelog: [Android][Fixed] Blob content provider did not work in new arch Reviewed By: alanleedev Differential Revision: D99836114
javache
force-pushed
the
export-D99836114
branch
from
c73603c to
c1a18cf
Compare
meta-codesync
bot
changed the title
|
This pull request has been merged in 05ea94c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Blob images in RNTester work
Changelog: [Android][Fixed] Blob content provider did not work in new arch
Reviewed By: alanleedev
Differential Revision: D99836114