Skip to content

Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403)#56403

Open
javache wants to merge 1 commit intofacebook:mainfrom
javache:export-D98717252
Open

Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403)#56403
javache wants to merge 1 commit intofacebook:mainfrom
javache:export-D98717252

Conversation

@javache
Copy link
Copy Markdown
Member

@javache javache commented Apr 9, 2026

Summary:

Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function

Changelog: [Internal]

Reviewed By: zeyap

Differential Revision: D98717252

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2026
@facebook-github-tools facebook-github-tools bot added p: Facebook Partner: Facebook Partner labels Apr 9, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Apr 9, 2026

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98717252.

@meta-codesync meta-codesync bot changed the title Fix unsafe JSI access in UIManagerBinding::startViewTransition onReadyCallback Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Apr 9, 2026
@javache javache force-pushed the export-D98717252 branch from afc033d to d6bfa60 Compare April 9, 2026 20:22
javache added a commit to javache/react-native that referenced this pull request Apr 9, 2026
…on (facebook#56403)

Summary:

Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function

Changelog: [Internal]

Differential Revision: D98717252
javache added a commit to javache/react-native that referenced this pull request Apr 9, 2026
…on (facebook#56403)

Summary:
Pull Request resolved: facebook#56403

Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function

Changelog: [Internal]

Differential Revision: D98717252
@javache javache force-pushed the export-D98717252 branch from d6bfa60 to 30ff85e Compare April 9, 2026 20:27
@meta-codesync meta-codesync bot changed the title Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Apr 9, 2026
@meta-codesync meta-codesync bot changed the title Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Apr 9, 2026
javache added a commit to javache/react-native that referenced this pull request Apr 9, 2026
…on (facebook#56403)

Summary:

Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function

Changelog: [Internal]

Differential Revision: D98717252
@javache javache force-pushed the export-D98717252 branch from 30ff85e to ebb626d Compare April 9, 2026 20:33
…on (facebook#56403)

Summary:
Pull Request resolved: facebook#56403

Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function

Changelog: [Internal]

Reviewed By: zeyap

Differential Revision: D98717252
@javache javache force-pushed the export-D98717252 branch from ebb626d to ee8e9ee Compare April 9, 2026 20:37
@meta-codesync meta-codesync bot changed the title Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403) Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant