Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403)#56403
Open
javache wants to merge 1 commit intofacebook:mainfrom
Open
Simplify jsi::Function storage in UIManagerBinding::startViewTransition (#56403)#56403javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
afc033d to
d6bfa60
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 9, 2026
…on (facebook#56403) Summary: Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function Changelog: [Internal] Differential Revision: D98717252
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 9, 2026
…on (facebook#56403) Summary: Pull Request resolved: facebook#56403 Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function Changelog: [Internal] Differential Revision: D98717252
d6bfa60 to
30ff85e
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 9, 2026
…on (facebook#56403) Summary: Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function Changelog: [Internal] Differential Revision: D98717252
30ff85e to
ebb626d
Compare
…on (facebook#56403) Summary: Pull Request resolved: facebook#56403 Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function Changelog: [Internal] Reviewed By: zeyap Differential Revision: D98717252
ebb626d to
ee8e9ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Document the threading contract on UIManagerViewTransitionDelegate::startViewTransition and simplifying how we track the jsi::Function
Changelog: [Internal]
Reviewed By: zeyap
Differential Revision: D98717252