Skip to content

Commit 1fae59a

Browse files
committed
test: Better place for partial renderer deprecated lifecycle warning
1 parent 79e14c1 commit 1fae59a

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

packages/react-dom/src/__tests__/ReactDOMServerLifecycles-test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ describe('ReactDOMServerLifecycles', () => {
213213
it('should invoke both deprecated and new lifecycles if both are present', () => {
214214
const log = [];
215215

216-
class MyComponent extends React.Component {
216+
class Component extends React.Component {
217217
componentWillMount() {
218218
log.push('componentWillMount');
219219
}
@@ -225,10 +225,8 @@ describe('ReactDOMServerLifecycles', () => {
225225
}
226226
}
227227

228-
expect(() => ReactDOMServer.renderToString(<MyComponent />)).toWarnDev(
229-
'componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.\n\n' +
230-
'* Move code from componentWillMount to componentDidMount (preferred in most cases) or the constructor.\n\n' +
231-
'Please update the following components: MyComponent',
228+
expect(() => ReactDOMServer.renderToString(<Component />)).toWarnDev(
229+
'componentWillMount has been renamed',
232230
);
233231
expect(log).toEqual(['componentWillMount', 'UNSAFE_componentWillMount']);
234232
});
@@ -287,19 +285,21 @@ describe('ReactDOMServerLifecycles', () => {
287285
});
288286

289287
it('should warn about deprecated lifecycle hooks', () => {
290-
class Component extends React.Component {
288+
class MyComponent extends React.Component {
291289
componentWillMount() {}
292290
render() {
293291
return null;
294292
}
295293
}
296294

297-
expect(() => ReactDOMServer.renderToString(<Component />)).toWarnDev(
298-
'componentWillMount has been renamed',
295+
expect(() => ReactDOMServer.renderToString(<MyComponent />)).toWarnDev(
296+
'componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.\n\n' +
297+
'* Move code from componentWillMount to componentDidMount (preferred in most cases) or the constructor.\n\n' +
298+
'Please update the following components: MyComponent',
299299
);
300300

301301
// De-duped
302-
ReactDOMServer.renderToString(<Component />);
302+
ReactDOMServer.renderToString(<MyComponent />);
303303
});
304304

305305
describe('react-lifecycles-compat', () => {

0 commit comments

Comments
 (0)