grammar: Allow pipe character | in unquoted strings#1850
Merged
Jasha10 merged 4 commits intofacebookresearch:mainfrom Oct 22, 2021
Merged
grammar: Allow pipe character | in unquoted strings#1850Jasha10 merged 4 commits intofacebookresearch:mainfrom
| in unquoted strings#1850Jasha10 merged 4 commits intofacebookresearch:mainfrom
Conversation
odelalleau
requested changes
Oct 11, 2021
Collaborator
odelalleau
left a comment
odelalleau
left a comment
There was a problem hiding this comment.
Looks good to me, but yes we'll need the same change in OmegaConf's grammar as well.
Collaborator
|
Oh, can you add a news fragment as well? |
facebook-github-bot
added
the
CLA Signed
odelalleau
requested changes
Oct 14, 2021
Collaborator
odelalleau
left a comment
odelalleau
left a comment
There was a problem hiding this comment.
Thanks for the changes, sorry I had forgotten something else in my first review: the parser grammar is included in the doc (https://hydra.cc/docs/advanced/override_grammar/basic) and the doc thus needs to be also updated.
Collaborator
Author
|
Aah yes, good point. Updated in a32f168. |
odelalleau
approved these changes
Oct 19, 2021
Collaborator
odelalleau
left a comment
odelalleau
left a comment
There was a problem hiding this comment.
Go! (preferably after CI is fixed)
Jasha10
force-pushed
the
allow_pipe_in_unquoted_strings
branch
from
a32f168 to
ee14dc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to Omry's comment here suggesting that Hydra's override grammar allow the pipe character
|in unquoted strings.If we decide to move forward with this PR, I think we should update OmegaConf's grammar too.