remove handling of deprecated "old optional" defaults list syntax#1952
Merged
Jasha10 merged 1 commit intofacebookresearch:mainfrom Apr 16, 2022
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
I'm marking this PR as a draft until the new Hydra base_version functionality is in place. |
Jasha10
force-pushed
the
remove_old_optional_handling
branch
from
6ce2bbe to
d770fd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions of hydra, the following two defaults lists were equivalent:
This PR removes support for the
formerlatter syntax.