remove support for deprecated hydra override syntax#2056
Merged
Jasha10 merged 1 commit intofacebookresearch:mainfrom Apr 22, 2022
Merged
Conversation
Contributor
|
This pull request introduces 1 alert when merging 8dfea9d into c707ac2 - view on LGTM.com new alerts:
|
dab9948 to
4d6e5f7
Compare
Contributor
|
thanks @Jasha10 |
Collaborator
Author
|
Using the old style override: defaults:
- hydra/job_logging: colorlog
- hydra/hydra_logging: colorlog |
Collaborator
Author
|
I'm marking this PR as a draft until the new Hydra base_version functionality is in place. |
d77e69b to
8d9abc1
Compare
8d9abc1 to
91bc0c5
Compare
jieru-hu
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated support for overriding
hydraconfig groups without use of the keywordoverride(see this deprecation notice).Removing this deprecated behavior enables the use of custom subgroups of the top-level hydra config.
Example:
Suppose we have a directory tree like this:
Let's say
my_app.pyis a minimal Hydra app:Before this PR, it is impossible to add
hydra/run: my_runto the defaults list (sincehydra/rundoes not appear in the defaults list ofHydraConf).This enabled use-case is relevant to discussion #2051.