Skip to content

Conversation

@BYVoid
Copy link
Contributor

@BYVoid BYVoid commented Nov 1, 2024

Similar to lemire/fast_double_parser#79, I would like to contribute this excellent library to Bazel. Please take a look.

build --cxxopt="--std=c++17" set in .bazelrc only affects the tests. When the library is imported by other project, they can specify whatever C++ version.

@lemire
Copy link
Member

lemire commented Nov 1, 2024

Running tests

@BYVoid
Copy link
Contributor Author

BYVoid commented Nov 1, 2024

You can run bazel test //tests/....

I did not add "exhaustive" tests because they were too slow. Is this expected?

@lemire
Copy link
Member

lemire commented Nov 1, 2024

@BYVoid

I did not add "exhaustive" tests because they were too slow. Is this expected?

Yes.

This library is used in mission critical settings so it has an insane amount of testing.

@lemire
Copy link
Member

lemire commented Nov 1, 2024

@BYVoid If you recommend merging, I am fine with this.

@BYVoid
Copy link
Contributor Author

BYVoid commented Nov 1, 2024

Yes. I can make another pull request to add exhaustive tests into the Bazel build file. The reason why I did not add them is for the purpose of CI. CI should not run tests which are too expensive.

I am thinking about moving them into a subdirectory under tests named 'exhaustive', so that it would be easier to know which ones are, and we can easily exclude them in from Bazel registry CI.

@lemire
Copy link
Member

lemire commented Nov 1, 2024

Ok. Merging.

@lemire lemire merged commit e800cab into fastfloat:main Nov 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants