Skip to content

Commit 3471fb4

Browse files
committed
fix: add mongodb to kubebuilder Enum annotations for OnlineStoreDBStorePersistence
The +kubebuilder:validation:Enum annotation on the Type field of OnlineStoreDBStorePersistence was not updated when mongodb was added to ValidOnlineStoreDBStorePersistenceTypes. This annotation drives CRD OpenAPI schema validation at Kubernetes admission time, so any FeatureStore CR specifying type: mongodb would be rejected by the API server. Updated both api/v1 and api/v1alpha1. Signed-off-by: Casey Clements <casey.clements@mongodb.com>
1 parent 966f8d6 commit 3471fb4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

infra/feast-operator/api/v1/featurestore_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ type OnlineStoreFilePersistence struct {
450450
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
451451
type OnlineStoreDBStorePersistence struct {
452452
// Type of the persistence type you want to use.
453-
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
453+
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb
454454
Type string `json:"type"`
455455
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
456456
SecretRef corev1.LocalObjectReference `json:"secretRef"`

infra/feast-operator/api/v1alpha1/featurestore_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ type OnlineStoreFilePersistence struct {
371371
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
372372
type OnlineStoreDBStorePersistence struct {
373373
// Type of the persistence type you want to use.
374-
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
374+
// +kubebuilder:validation:Enum=snowflake.online;redis;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid;mongodb
375375
Type string `json:"type"`
376376
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
377377
SecretRef corev1.LocalObjectReference `json:"secretRef"`

0 commit comments

Comments
 (0)