Skip to content

Commit 35e2701

Browse files
committed
Fixing a lint error; Fixing a regression caused by googleapis/google-auth-library-python#324
1 parent 3621162 commit 35e2701

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

snippets/auth/index.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,9 @@ def sign_in_with_email_link():
635635
# [END sign_in_with_email_link]
636636

637637
def send_custom_email(email, display_name, link):
638-
pass
638+
del email
639+
del display_name
640+
del link
639641

640642
initialize_sdk_with_service_account()
641643
initialize_sdk_with_application_default()

tests/test_token_gen.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def test_sign_with_iam(self):
207207
iam_resp = '{{"signature": "{0}"}}'.format(signature)
208208
_overwrite_iam_request(app, testutils.MockRequest(200, iam_resp))
209209
custom_token = auth.create_custom_token(MOCK_UID, app=app).decode()
210-
assert custom_token.endswith('.' + signature)
210+
assert custom_token.endswith('.' + signature.rstrip('='))
211211
self._verify_signer(custom_token, 'test-service-account')
212212
finally:
213213
firebase_admin.delete_app(app)
@@ -241,7 +241,7 @@ def test_sign_with_discovered_service_account(self):
241241
request.response = testutils.MockResponse(
242242
200, '{{"signature": "{0}"}}'.format(signature))
243243
custom_token = auth.create_custom_token(MOCK_UID, app=app).decode()
244-
assert custom_token.endswith('.' + signature)
244+
assert custom_token.endswith('.' + signature.rstrip('='))
245245
self._verify_signer(custom_token, 'discovered-service-account')
246246
assert len(request.log) == 2
247247
assert request.log[0][1]['headers'] == {'Metadata-Flavor': 'Google'}

0 commit comments

Comments
 (0)