Skip to content

[1.x] chore: change private to protected, allowing extensibility #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imorland merged 1 commit into from
Nov 19, 2024
Merged

[1.x] chore: change private to protected, allowing extensibility #4119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/core/src/Forum/Auth/ResponseFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function make(string $provider, string $identifier, callable $configureRe
));
}

private function makeResponse(array $payload): HtmlResponse
protected function makeResponse(array $payload): HtmlResponse
{
$content = sprintf(
'<script>window.close(); window.opener.app.authenticationComplete(%s);</script>',
Expand All @@ -72,7 +72,7 @@ private function makeResponse(array $payload): HtmlResponse
return new HtmlResponse($content);
}

private function makeLoggedInResponse(User $user)
protected function makeLoggedInResponse(User $user)
{
$response = $this->makeResponse(['loggedIn' => true]);

Expand Down