Skip to content

[2.x] chore: allow LaravelServiceProvider or AbstractServiceProvider #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imorland merged 1 commit into from
Jan 24, 2026
Merged

[2.x] chore: allow LaravelServiceProvider or AbstractServiceProvider #4349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion framework/core/src/Extend/ServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Flarum\Extension\Extension;
use Flarum\Foundation\AbstractServiceProvider;
use Illuminate\Contracts\Container\Container;
use Illuminate\Support\ServiceProvider as LaravelServiceProvider;

class ServiceProvider implements ExtenderInterface
{
Expand All @@ -24,7 +25,7 @@ class ServiceProvider implements ExtenderInterface
* Please read our documentation about service providers for recommendations.
* @see https://docs.flarum.org/extend/service-provider/
*
* @param class-string<AbstractServiceProvider> $serviceProviderClass The ::class attribute of the service provider class.
* @param class-string<AbstractServiceProvider|LaravelServiceProvider> $serviceProviderClass The ::class attribute of the service provider class.
*/
public function register(string $serviceProviderClass): self
{
Expand Down
Loading