Avoid infinite parse error logging loopback#1594
Merged
Watson1978 merged 2 commits intofluent:masterfrom Mar 3, 2026
Merged
Conversation
Contributor
Author
|
changed not to use use_default. (ensure to fallback) |
Contributor
Author
|
See #1577 (comment) How to verify:
Expect no '\\\' escape hell. |
Watson1978
reviewed
Mar 3, 2026
Without it, if it reads unexpected format, error log is emitted and also read. Then it also cause parse error again. During that process, '\' will be escaped and as a result, make pod evict. 1. emit parse error when it accepts unexpected format 2. Fluentd emits with pattern not matched: "..." warning 3. Kubeneters collect such a warning into /var/log/containsers/fluentd-xxx.log 4. If user didn't set FLUENT_CONTAINER_TAIL_EXCLUDE_PATH explicitly, collect fluentd-xxx.log which contains warning message 5. it results in parse error again... Thus in infinite parse error, '\' will be escaped and escaped ... Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Watson1978
reviewed
Mar 3, 2026
Co-authored-by: Shizuo Fujita <watson1978@gmail.com> Signed-off-by: Kentaro Hayashi <kenhys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without it, if it reads unexpected format, error log is emitted and also read. Then it also cause parse error again.
During that process, '' will be escaped and as a result, make pod evict.