Merged
Conversation
Member
|
Contributor
Author
|
@demchenkoalex Done 🚀 |
demchenkoalex
approved these changes
Jun 8, 2025
aljanshere
pushed a commit
to aljanshere/flutter_chat_ui
that referenced
this pull request
Jun 18, 2025
* Add pinned bool to Message model * Add edited information on TextMessage * Make pin optional * Remove editedByUserId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #797
pinnedbool field onMessageTook the opportunity to add
editedAt,editedByUserIdonTextMessagewhich is also a classic usecase to display when a message as been edited (maybe it should be onMessage).updatedAtis not enough because a message can be updated for many reasons (like adding previewData).If you are ok with those change I could propose an update to
FlyerChatTextMessageandSimpleTextMessageto display to "Modified" mention.Also I'm wondering if
-a
deletedByUserIdfield would by a classic usecase too. (In many apps admins can delete other people messages).