fix: perf improvements

[demchenkoalex]

No description provided.

[demchenkoalex]

bugbot run

[demchenkoalex]

Bug: Send Icon Color Parameter Inverted

It's fine since it is a new API, not public facing - I want it inverted.

[demchenkoalex]

bugbot run

[cursor]

Bug: Send Icon Inconsistency

The send icon's visual state is inconsistent with its functional behavior. The onChanged callback now uses value.trim().isNotEmpty to determine if the text field has content, which affects the send icon's color (making it appear disabled for whitespace-only input). However, the send functionality, triggered by _handleSubmitted, still uses the untrimmed text, allowing messages consisting solely of whitespace to be sent despite the icon's disabled appearance.

packages/flutter_chat_ui/lib/src/composer.dart#L274-L340

flutter_chat_ui/packages/flutter_chat_ui/lib/src/composer.dart

Lines 274 to 340 in f79e323

	onChanged: (value) {
	_hasTextNotifier.value = value.trim().isNotEmpty;
	},
	textInputAction: widget.textInputAction,
	keyboardAppearance: widget.keyboardAppearance,
	autocorrect: widget.autocorrect ?? true,
	autofocus: widget.autofocus,
	textCapitalization: widget.textCapitalization,
	keyboardType: widget.keyboardType,
	focusNode: _focusNode,
	maxLength: widget.maxLength,
	minLines: widget.minLines,
	maxLines: widget.maxLines,
	),
	),
	SizedBox(width: widget.gap),
	widget.sendIcon != null
	? ValueListenableBuilder<bool>(
	valueListenable: _hasTextNotifier,
	builder: (context, hasText, child) {
	final iconColor =
	hasText
	? (widget.sendIconColor ??
	theme.onSurface.withValues(alpha: 0.5))
	: (widget.emptyFieldSendIconColor ??
	widget.sendIconColor ??
	theme.onSurface.withValues(alpha: 0.5));
	return IconButton(
	icon: widget.sendIcon!,
	color: iconColor,
	onPressed:
	() => _handleSubmitted(_textController.text),
	);
	},
	)
	: const SizedBox.shrink(),
	],
	),
	),
	],
	),
	),
	),
	);
	}
	void _measure() {
	if (!mounted) return;
	final renderBox = _key.currentContext?.findRenderObject() as RenderBox?;
	if (renderBox != null) {
	final height = renderBox.size.height;
	final bottomSafeArea = MediaQuery.of(context).padding.bottom;
	context.read<ComposerHeightNotifier>().setHeight(
	// only set real height of the composer, ignoring safe area
	widget.handleSafeArea == true ? height - bottomSafeArea : height,
	);
	}
	}
	void _handleSubmitted(String text) {
	if (text.isNotEmpty) {
	context.read<OnMessageSendCallback?>()?.call(text);
	_textController.clear();
	}

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎