Skip to content

(feat): fix link adding underline with color#858

Merged
demchenkoalex merged 2 commits intoflyerhq:mainfrom
GrandjeanG:feat/fix_link_color
Nov 3, 2025
Merged

(feat): fix link adding underline with color#858
demchenkoalex merged 2 commits intoflyerhq:mainfrom
GrandjeanG:feat/fix_link_color

Conversation

@GrandjeanG
Copy link
Copy Markdown
Contributor

Currently links are not taking the color link, I added this PR so that we can still add a text decoration with specific color to the links.
I was not able to change the text color, even with many different techniques.

@TJMusiitwa
Copy link
Copy Markdown

@demchenkoalex
It would be great, if we could get this fix launched as for some reason on the version I am using, even setting the links color does not seem to modify it
image

The link is there but a user can't tell that it is there.

@TJMusiitwa
Copy link
Copy Markdown

Hey @demchenkoalex, sorry to ask again, just hoping if you have some time soon, this could be able merged and deployed. This is all blocking our migration from v1 to deploying our apps with v2. Thank you.

@demchenkoalex demchenkoalex merged commit bb9f814 into flyerhq:main Nov 3, 2025
1 check passed
@demchenkoalex
Copy link
Copy Markdown
Member

sorry about that, deploying now

@demchenkoalex
Copy link
Copy Markdown
Member

guys this is not fixed by this PR 😅 this PR adds decoration, but you still can't set link color - it is a bug in gpt_markdown - no matter what I do I can't set color, unless I do some recursion or create completely new span which will drop formatting.

@demchenkoalex
Copy link
Copy Markdown
Member

okay I fixed it anyway - used recursion. Added a todo to remove when the bug is fixed in gpt_markdown. API will change a bit compared to this PR:

all params are optional with no defaults:
linksDecoration <- set the links decoration (like underline) - defaults to nothing
sentLinksColor, receivedLinksColor, sentLinksDecorationColor, receivedLinksDecorationColor <- customise colors of both links and decoration separately. Decoration defaults to the link color (if you'd like same color it is enough to pass only links color)

@demchenkoalex
Copy link
Copy Markdown
Member

published v2.5.2 of flyer_chat_text_message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants