Skip to content

Commit a246964

Browse files
committed
fix some warnings
1 parent b4b4b3a commit a246964

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

core/sdl/dreamconn.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ bool DreamConn::needsRefresh() {
151151

152152
return true;
153153
}
154+
return false;
154155
}
155156

156157
// Sends a message to query for expansion devices.

core/sdl/dreampicoport.cpp

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ class DreamPicoPortSerialHandler
403403
}
404404

405405
std::vector<uint32_t> words;
406-
bool valid = false;
407406
const char* iter = response.c_str();
408407
const char* eol = iter + response.size();
409408

@@ -429,12 +428,8 @@ class DreamPicoPortSerialHandler
429428
}
430429

431430
// Invalid if a partial word was given
432-
valid = ((i == 4) || (i == 0));
433-
434431
if (i == 4)
435-
{
436432
words.push_back(word);
437-
}
438433
}
439434
}
440435
else
@@ -472,12 +467,8 @@ class DreamPicoPortSerialHandler
472467
}
473468

474469
// Invalid if a partial word was given
475-
valid = ((i == 8) || (i == 0));
476-
477470
if (i == 8)
478-
{
479471
words.push_back(word);
480-
}
481472
}
482473
}
483474

@@ -693,7 +684,7 @@ int DreamPicoPort::getBus() const {
693684

694685
u32 DreamPicoPort::getFunctionCode(int forPort) const {
695686
u32 mask = 0;
696-
if (peripherals.size() > forPort) {
687+
if ((int)peripherals.size() > forPort) {
697688
for (const auto& peripheral : peripherals[forPort]) {
698689
mask |= peripheral[0];
699690
}
@@ -704,7 +695,7 @@ u32 DreamPicoPort::getFunctionCode(int forPort) const {
704695

705696
std::array<u32, 3> DreamPicoPort::getFunctionDefinitions(int forPort) const {
706697
std::array<u32, 3> arr{0, 0, 0};
707-
if (peripherals.size() > forPort) {
698+
if ((int)peripherals.size() > forPort) {
708699
std::size_t idx = 0;
709700
for (const auto& peripheral : peripherals[forPort]) {
710701
arr[idx++] = SWAP32(peripheral[1]);

0 commit comments

Comments
 (0)