fix: Nullability in SentrySwizzleWrapperHelper (#6970)

* fix: Nullability in SentrySwizzleWrapperHelper

* Add test

* Improvements

Author: noahsmartin

CHANGELOG.md

@@ -7,6 +7,10 @@
 - Add attributes data to `SentryScope` (#6830)
 - Add `SentryScope` attributes into log messages (#6834)
 
+### Fixes
+
+- Fixes crash when null values are passed to `UIApplication sendAction:to:from:forEvent:` (#6970)
+
 ## 9.0.0
 
 This changelog lists every breaking change. For a high-level overview and upgrade guidance, see the [migration guide](https://docs.sentry.io/platforms/apple/migration/).

Samples/iOS-SwiftUI/iOS-SwiftUI-UITests/UIApplicationSwizzleTests.swift

@@ -0,0 +1,17 @@
+import SentrySampleShared
+import XCTest
+
+final class UIApplicationSwizzleTests: XCTestCase {
+  
+  // Tests for the crash first reported in https://github.com/getsentry/sentry-cocoa/issues/6966
+  func testSendEvent() {
+    let app = XCUIApplication()
+    app.launchArguments.append(contentsOf: [
+        SentrySDKOverrides.Other.disableSpotlight.rawValue
+    ])
+    app.safelyLaunch()
+    
+    app.buttons["UIApplication sendEmptyEvent"].tap()
+  }
+  
+}

Samples/iOS-SwiftUI/iOS-SwiftUI/ContentView.swift

@@ -176,6 +176,10 @@ struct ContentView: View {
                             Button(action: captureTransactionAction) {
                                 Text("Capture Transaction")
                             }
+                            // This is used by a UI test since UIApplication.shared is nil in unit tests.
+                            Button("UIApplication sendEmptyEvent") {
+                              UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
+                            }
                             Button(action: showTTD) {
                                 Text("Show TTD")
                             }.sentryReplayUnmask()

Sources/Sentry/SentrySwizzleWrapperHelper.m

@@ -8,7 +8,8 @@
 
 @implementation SentrySwizzleWrapperHelper
 
-+ (void)swizzle:(void (^)(SEL action, id target, id sender, UIEvent *event))callback;
++ (void)swizzle:(void (^)(SEL action, _Nullable id target, _Nullable id sender,
+                    UIEvent *_Nullable event))callback;
 {
 #    pragma clang diagnostic push
 #    pragma clang diagnostic ignored "-Wshadow"

Sources/Sentry/include/SentrySwizzleWrapperHelper.h

@@ -8,7 +8,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface SentrySwizzleWrapperHelper : NSObject
 
-+ (void)swizzle:(void (^)(SEL action, id target, id sender, UIEvent *event))callback;
++ (void)swizzle:(void (^)(SEL action, _Nullable id target, _Nullable id sender,
+                    UIEvent *_Nullable event))callback;
 
 @end