Skip to content

Commit c7a1563

Browse files
authored
ci: Only use Cirrus Runners on UI Tests (#6776)
* ci: Use Cirrus Runners only on UI Tests * Bump xcode 26.1 to 26.1.1
1 parent 0ecea77 commit c7a1563

File tree

1 file changed

+15
-42
lines changed

1 file changed

+15
-42
lines changed

.github/workflows/ui-tests.yml

Lines changed: 15 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ jobs:
4848
fail-fast: false
4949
matrix:
5050
runner:
51-
- GitHub
5251
- Cirrus Labs
5352
job_id:
5453
- ios_objc
@@ -68,15 +67,12 @@ jobs:
6867
fastlane_command: ui_tests_${{matrix.target}}
6968
xcode_version: 16.4
7069
build_with_make: true
71-
macos_version: ${{ matrix.runner == 'Cirrus Labs' && 'sequoia' || 'macos-15' }}
72-
run_on_cirrus_labs: ${{ matrix.runner == 'Cirrus Labs' }}
70+
macos_version: "sequoia"
71+
run_on_cirrus_labs: true
7372
codecov_test_analytics: true
7473
test-destination-os: ${{matrix.test_destination_os}}
7574
device: ${{matrix.device}}
7675
files_suffix: _${{matrix.target}}_${{matrix.runner}}
77-
# Github doesn't allow using matrix variables in if conditions, so we pass it to the common workflow and skip there.
78-
# This lets us skip the job if it's a push to the main branch and the runner is Cirrus Labs.
79-
should_skip: ${{ ( github.event_name != 'push' || github.ref != 'refs/heads/main' ) && matrix.runner == 'Cirrus Labs' }}
8076
secrets:
8177
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
8278

@@ -90,22 +86,19 @@ jobs:
9086
build_with_make: true
9187
codecov_test_analytics: true
9288
xcode_version: 16.4
93-
macos_version: ${{ matrix.runner == 'Cirrus Labs' && 'sequoia' || 'macos-15' }}
94-
run_on_cirrus_labs: ${{ matrix.runner == 'Cirrus Labs' }}
89+
macos_version: "sequoia"
90+
run_on_cirrus_labs: true
9591
test-destination-os: "18.6"
9692
device: iPhone 16 Pro
9793
files_suffix: _swiftui_-${{matrix.runner}}
98-
# Github doesn't allow using matrix variables in if conditions, so we pass it to the common workflow and skip there.
99-
# This lets us skip the job if it's a push to the main branch and the runner is Cirrus Labs.
100-
should_skip: ${{ ( github.event_name != 'push' || github.ref != 'refs/heads/main' ) && matrix.runner == 'Cirrus Labs' }}
10194
secrets:
10295
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
10396
strategy:
10497
fail-fast: false
10598
matrix:
10699
runner:
107-
- GitHub
108100
- Cirrus Labs
101+
109102
ui-tests-swift:
110103
if: github.event_name != 'pull_request' || needs.files-changed.outputs.run_ui_tests_for_prs == 'true'
111104
needs: files-changed
@@ -115,7 +108,6 @@ jobs:
115108
fail-fast: false
116109
matrix:
117110
runner:
118-
- GitHub
119111
- Cirrus Labs
120112
job_id:
121113
- ios_17
@@ -125,55 +117,40 @@ jobs:
125117
# iOS 17 - Use iOS 17.5 runtime on macOS-15 with Xcode 16.4
126118
- job_id: ios_17
127119
name: iOS 17
128-
runs_on: macos-14
129-
runs_on_cirrus: sequoia
130-
xcode: "16.2"
131-
xcode_cirrus: "16.4"
120+
runs_on: sequoia
121+
xcode: "16.4"
132122
test_destination_os: "17.5"
133123
platform: "iOS"
134-
install_platforms: false
135-
create_device: true
136124
device: iPhone 15 Pro
137125

138126
# iOS 18 - Use pre-installed iOS 18.4 runtime on macOS-15
139127
- job_id: ios_18
140128
name: iOS 18
141-
runs_on: macos-15
142-
runs_on_cirrus: sequoia
129+
runs_on: sequoia
143130
xcode: "16.4"
144131
test_destination_os: "18.4"
145132
platform: "iOS"
146133
device: iPhone 16 Pro
147-
install_platforms: false
148-
create_device: false
149134

150135
# iOS 26 - Download iOS 26.1 beta runtime on macOS-26
151136
- job_id: ios_26
152137
name: iOS 26
153-
runs_on: macos-26
154-
runs_on_cirrus: tahoe
155-
xcode: "26.1"
138+
runs_on: tahoe
139+
xcode: "26.1.1"
156140
test_destination_os: "26.1"
157-
install_platforms: true
158141
platform: "iOS"
159-
create_device: true
160142
device: iPhone 17 Pro
161143
with:
162144
fastlane_command: ui_tests_ios_swift
163145
files_suffix: _xcode_${{matrix.xcode}}-${{matrix.device}}-${{matrix.runner}}
164146
build_with_make: true
165-
macos_version: ${{matrix.runner == 'Cirrus Labs' && matrix.runs_on_cirrus || matrix.runs_on}}
166-
run_on_cirrus_labs: ${{ matrix.runner == 'Cirrus Labs' }}
147+
macos_version: ${{matrix.runs_on}}
148+
run_on_cirrus_labs: true
167149
codecov_test_analytics: true
168-
xcode_version: ${{ matrix.runner == 'Cirrus Labs' && matrix.xcode_cirrus || matrix.xcode}}
150+
xcode_version: ${{ matrix.xcode}}
169151
test-destination-os: ${{matrix.test_destination_os}}
170-
install_platforms: ${{matrix.install_platforms}}
171152
platform: ${{matrix.platform}}
172-
create_device: ${{matrix.create_device}}
173153
device: ${{matrix.device}}
174-
# Github doesn't allow using matrix variables in if conditions, so we pass it to the common workflow and skip there.
175-
# This lets us skip the job if it's a push to the main branch and the runner is Cirrus Labs.
176-
should_skip: ${{ ( github.event_name != 'push' || github.ref != 'refs/heads/main' ) && matrix.runner == 'Cirrus Labs' }}
177154
secrets:
178155
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
179156

@@ -186,21 +163,17 @@ jobs:
186163
fail-fast: false
187164
matrix:
188165
runner:
189-
- GitHub
190166
- Cirrus Labs
191167
with:
192168
fastlane_command: ui_tests_ios_swift6
193169
xcode_version: 16.4
194170
build_with_make: true
195-
macos_version: ${{matrix.runner == 'Cirrus Labs' && 'sequoia' || 'macos-15'}}
196-
run_on_cirrus_labs: ${{matrix.runner == 'Cirrus Labs'}}
171+
macos_version: "sequoia"
172+
run_on_cirrus_labs: true
197173
codecov_test_analytics: true
198174
device: iPhone 16 Pro
199175
test-destination-os: "18.4"
200176
files_suffix: _swift6_-${{matrix.runner}}
201-
# Github doesn't allow using matrix variables in if conditions, so we pass it to the common workflow and skip there.
202-
# This lets us skip the job if it's a push to the main branch and the runner is Cirrus Labs.
203-
should_skip: ${{ ( github.event_name != 'push' || github.ref != 'refs/heads/main' ) && matrix.runner == 'Cirrus Labs' }}
204177
secrets:
205178
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
206179

0 commit comments

Comments
 (0)