Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Aug 27, 2025

As the comment on this property already stated, it should be the default in V9

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4730460

@noahsmartin noahsmartin marked this pull request as ready for review August 27, 2025 18:28
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4f5b2c9). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6008   +/-   ##
========================================
  Coverage        ?   86.697%           
========================================
  Files           ?       435           
  Lines           ?     37067           
  Branches        ?     17396           
========================================
  Hits            ?     32136           
  Misses          ?      4887           
  Partials        ?        44           
Files with missing lines Coverage Δ
Sources/Sentry/SentryAppStartTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 97.484% <100.000%> (ø)
Sources/Sentry/SentyOptionsInternal.m 99.687% <100.000%> (ø)
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <100.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5b2c9...4730460. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.54 ms 1243.29 ms 23.74 ms
Size 23.75 KiB 971.81 KiB 948.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fd5961e 1210.59 ms 1235.57 ms 24.98 ms
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
718c372 1220.09 ms 1235.15 ms 15.06 ms
52f3b6e 1219.57 ms 1239.70 ms 20.13 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
d66f082 1227.08 ms 1247.04 ms 19.96 ms
1b9991e 1233.45 ms 1256.61 ms 23.17 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
87fb58a 1233.12 ms 1257.17 ms 24.04 ms
5196f0d 1213.35 ms 1231.37 ms 18.02 ms

App size

Revision Plain With Sentry Diff
fd5961e 23.74 KiB 874.07 KiB 850.32 KiB
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
718c372 23.75 KiB 920.65 KiB 896.90 KiB
52f3b6e 23.75 KiB 920.54 KiB 896.79 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
d66f082 23.75 KiB 928.85 KiB 905.10 KiB
1b9991e 23.75 KiB 908.01 KiB 884.26 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
87fb58a 23.75 KiB 919.91 KiB 896.16 KiB
5196f0d 23.75 KiB 876.93 KiB 853.19 KiB

Previous results on branch: performanceV2SDKV9

Startup times

Revision Plain With Sentry Diff
712e202 1239.35 ms 1261.18 ms 21.83 ms
eff8ef1 1214.24 ms 1258.57 ms 44.33 ms

App size

Revision Plain With Sentry Diff
712e202 23.75 KiB 927.07 KiB 903.33 KiB
eff8ef1 23.74 KiB 971.80 KiB 948.06 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to add a migration guide.

@noahsmartin noahsmartin force-pushed the performanceV2SDKV9 branch 3 times, most recently from 9f8afdf to eddbc1e Compare September 15, 2025 13:46
@noahsmartin noahsmartin merged commit e61a572 into main Sep 15, 2025
192 of 195 checks passed
@noahsmartin noahsmartin deleted the performanceV2SDKV9 branch September 15, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants