Add enable_logs, before_send_log as top-level options#4644
Merged
sentrivana merged 9 commits intomasterfrom Jul 31, 2025
Merged
Add enable_logs, before_send_log as top-level options#4644sentrivana merged 9 commits intomasterfrom
enable_logs, before_send_log as top-level options#4644sentrivana merged 9 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
+ Coverage 80.75% 80.79% +0.03%
==========================================
Files 156 156
Lines 16635 16643 +8
Branches 2831 2833 +2
==========================================
+ Hits 13434 13446 +12
+ Misses 2311 2306 -5
- Partials 890 891 +1
|
sentrivana
commented
Jul 30, 2025
Comment on lines
+904
to
+905
| # type: (Optional[Log]) -> None | ||
| if not has_logs_enabled(self.options) or log is None: |
Contributor
Author
There was a problem hiding this comment.
This is here because mypy was complaining about log not being Optional on line 962 (in the new diff) and the get_before_send_log function potentially returning None 🙄
sl0thentr0py
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
enable_logsandbefore_send_logto regular (non-experimental) SDK options. Keep supporting the experimental versions too, for backwards compat.Closes #4641