Skip to content

Commit fd99f96

Browse files
committed
fix(trace-waterfall): Add preventScrollReset to navigate call
The old browserHistory.replace shim automatically included preventScrollReset: true to replicate react-router 3 behavior. The new navigate call only passed {replace: true}, losing the scroll reset prevention which could cause unwanted scroll jumps during waterfall row focus changes.
1 parent c22890c commit fd99f96

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

static/app/views/performance/newTraceDetails/traceWaterfall.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ export function TraceWaterfall(props: TraceWaterfallProps) {
291291
node: nextNodePath,
292292
},
293293
},
294-
{replace: true}
294+
{replace: true, preventScrollReset: true}
295295
);
296296
queryStringAnimationTimeoutRef.current = null;
297297
}, debounce);

0 commit comments

Comments
 (0)