From 488267ea037a901c93aa4709d5c56c599c10c2b1 Mon Sep 17 00:00:00 2001 From: Matt Quinn Date: Fri, 13 Mar 2026 21:00:20 -0400 Subject: [PATCH 1/2] fix(performance): Hide Tags tab in transaction summary when EAP is enabled The Tags tab in the non-domain-view path is not relevant when the performance-transaction-summary-eap feature flag is enabled. Hide it using the TabList.Item hidden prop and add tests for the behavior. Co-Authored-By: Claude Opus 4.6 --- .../transactionSummary/header.spec.tsx | 40 +++++++++++++++++++ .../performance/transactionSummary/header.tsx | 7 +++- 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/static/app/views/performance/transactionSummary/header.spec.tsx b/static/app/views/performance/transactionSummary/header.spec.tsx index 8d93060a347ade..0ec49294401935 100644 --- a/static/app/views/performance/transactionSummary/header.spec.tsx +++ b/static/app/views/performance/transactionSummary/header.spec.tsx @@ -79,4 +79,44 @@ describe('Performance > Transaction Summary Header', () => { expect(await screen.findByRole('tab', {name: 'Overview'})).toBeInTheDocument(); }); + + it('should show Tags tab by default', async () => { + const {project, organization, router, eventView} = initializeData(); + + render( + + ); + + expect(await screen.findByRole('tab', {name: 'Tags'})).toBeInTheDocument(); + }); + + it('should hide Tags tab when EAP feature is enabled', async () => { + const {project, organization, router, eventView} = initializeData({ + features: ['performance-transaction-summary-eap'], + }); + + render( + , + {organization} + ); + + await screen.findByRole('tab', {name: 'Overview'}); + expect(screen.queryByRole('tab', {name: 'Tags'})).not.toBeInTheDocument(); + }); }); diff --git a/static/app/views/performance/transactionSummary/header.tsx b/static/app/views/performance/transactionSummary/header.tsx index 42a51d7a6ce4f9..db63ff448c168c 100644 --- a/static/app/views/performance/transactionSummary/header.tsx +++ b/static/app/views/performance/transactionSummary/header.tsx @@ -33,6 +33,7 @@ import {MobileHeader} from 'sentry/views/insights/pages/mobile/mobilePageHeader' import {MOBILE_LANDING_SUB_PATH} from 'sentry/views/insights/pages/mobile/settings'; import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters'; import Breadcrumb, {getTabCrumbs} from 'sentry/views/performance/breadcrumb'; +import {useTransactionSummaryEAP} from 'sentry/views/performance/eap/useTransactionSummaryEAP'; import {TAB_ANALYTICS} from 'sentry/views/performance/transactionSummary/pageLayout'; import {eventsRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionEvents/utils'; import {profilesRouteWithQuery} from 'sentry/views/performance/transactionSummary/transactionProfiles/utils'; @@ -125,6 +126,8 @@ export function TransactionHeader({ [getNewRoute, organization, location, projects, currentTab, navigate] ); + const isEAP = useTransactionSummaryEAP(); + function handleCreateAlertSuccess() { trackAnalytics('performance_views.summary.create_alert_clicked', { organization, @@ -319,7 +322,9 @@ export function TransactionHeader({ > {t('Overview')} {t('Sampled Events')} - {t('Tags')} + Date: Sat, 14 Mar 2026 01:40:40 +0000 Subject: [PATCH 2/2] fix(performance): Hide Tags tab for EAP users in domain view Add hidden={isEAP} prop to Tags TabList.Item in the tabList variable used by domain views (frontend/backend/mobile). This matches the fix already applied to the inline TabList rendering. Applied via @cursor push command --- static/app/views/performance/transactionSummary/header.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/static/app/views/performance/transactionSummary/header.tsx b/static/app/views/performance/transactionSummary/header.tsx index db63ff448c168c..71e2121ef80d49 100644 --- a/static/app/views/performance/transactionSummary/header.tsx +++ b/static/app/views/performance/transactionSummary/header.tsx @@ -160,7 +160,9 @@ export function TransactionHeader({ > {t('Overview')} {t('Sampled Events')} - {t('Tags')} +