Skip to content

Conversation

@zeek0x
Copy link
Contributor

@zeek0x zeek0x commented Oct 22, 2025

This PR

  • Make the side effects caused by the Go runtime version mockable
  • Improve the test coverage of debug to 100%

Pull Request Checklist

Please ensure your pull request meets the following requirements:

  • Open your pull request against the master branch.
  • All tests pass in available continuous integration systems (e.g., GitHub Actions).
  • Tests are added or modified as needed to cover code changes.
  • If the pull request introduces a new feature, the feature is documented in the docs/doc.md.

Thank you for contributing!

@zeek0x zeek0x changed the title test(debug): improve test test(debug): improve tests Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (3dc1cd6) to head (5bfdb10).
⚠️ Report is 223 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
- Coverage   99.21%   98.89%   -0.33%     
==========================================
  Files          42       44       +2     
  Lines        3182     2976     -206     
==========================================
- Hits         3157     2943     -214     
- Misses         17       22       +5     
- Partials        8       11       +3     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.88% <100.00%> (?)
-tags go_json 98.81% <100.00%> (?)
-tags nomsgpack 98.87% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.24 98.89% <100.00%> (?)
go-1.25 98.89% <100.00%> (?)
macos-latest 98.89% <100.00%> (-0.33%) ⬇️
ubuntu-latest 98.89% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zeek0x zeek0x force-pushed the test/improve-debug branch from bf0836c to 1c356ea Compare December 4, 2025 03:49
@zeek0x zeek0x marked this pull request as ready for review December 4, 2025 04:01
@zeek0x zeek0x changed the title test(debug): improve tests test(debug): improve the test coverage of debug.go to 100% Dec 4, 2025
@zeek0x zeek0x force-pushed the test/improve-debug branch from 1c356ea to 5bfdb10 Compare December 4, 2025 04:05
@appleboy appleboy added the test label Dec 5, 2025
@appleboy appleboy added this to the v1.12 milestone Dec 5, 2025
@appleboy appleboy merged commit 19b877f into gin-gonic:master Dec 5, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants