-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add Jule language #7175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Jule language #7175
Conversation
864316d to
edd6441
Compare
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This language is still a long way from meeting usage requirements so won't be merged soon, but I've just noticed that the sample are not real-world usage examples of the language. Please replace these with real-world samples and not contrived examples illustrating concepts of the language.
a56f4b3 to
96e660f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included a real-world usage sample for all extensions added in this PR
Why have you removed the two lines below this rather than filling them in? We need to know where the files come from and the license covering each for legal reasons: eg we can't include proprietary code. Please add back those lines and fill them in.
As for the samples:
Line 130 in 2409807
| **"Hello world" examples will not be accepted.** |
Usage will be reviewed again when the next release is made.
Co-authored-by: mertcandav <[email protected]> Signed-off-by: adam <[email protected]>
not sure because it was almost a year ago, but probably because as of opening this PR the samples didn't have sources nor licenses |
96e660f to
6599b0c
Compare
Checklist
#5f7489