Skip to content

Conversation

@adamperkowski
Copy link

@adamperkowski adamperkowski commented Dec 22, 2024

Checklist

@adamperkowski adamperkowski requested a review from a team as a code owner December 22, 2024 05:48
@Alhadis Alhadis changed the title add Jule language Add Jule language Dec 24, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language is still a long way from meeting usage requirements so won't be merged soon, but I've just noticed that the sample are not real-world usage examples of the language. Please replace these with real-world samples and not contrived examples illustrating concepts of the language.

@lildude lildude added the Stale label Sep 15, 2025
@adamperkowski adamperkowski force-pushed the lang/jule branch 2 times, most recently from a56f4b3 to 96e660f Compare November 14, 2025 01:25
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have included a real-world usage sample for all extensions added in this PR

Why have you removed the two lines below this rather than filling them in? We need to know where the files come from and the license covering each for legal reasons: eg we can't include proprietary code. Please add back those lines and fill them in.

As for the samples:

**"Hello world" examples will not be accepted.**

Usage will be reviewed again when the next release is made.

Co-authored-by: mertcandav <[email protected]>
Signed-off-by: adam <[email protected]>
@adamperkowski
Copy link
Author

Why have you removed the two lines below this rather than filling them in? We need to know where the files come from and the license covering each for legal reasons: eg we can't include proprietary code. Please add back those lines and fill them in.

not sure because it was almost a year ago, but probably because as of opening this PR the samples didn't have sources nor licenses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants