Skip to content

Commit d1a7580

Browse files
committed
Verify PR checks in a different job, with newer Node
1 parent 89f6321 commit d1a7580

File tree

1 file changed

+34
-9
lines changed

1 file changed

+34
-9
lines changed

.github/workflows/pr-checks.yml

Lines changed: 34 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,10 @@ jobs:
5252
- name: Verify compiled JS up to date
5353
run: .github/workflows/script/check-js.sh
5454

55-
- name: Verify PR checks up to date
56-
if: always()
57-
run: .github/workflows/script/verify-pr-checks.sh
58-
5955
- name: Run unit tests
6056
if: always()
6157
run: npm test
6258

63-
- name: Run pr-checks tests
64-
if: always()
65-
working-directory: pr-checks
66-
run: npm ci && npx tsx --test
67-
6859
- name: Lint
6960
if: always() && matrix.os != 'windows-latest'
7061
run: npm run lint-ci
@@ -76,6 +67,40 @@ jobs:
7667
sarif_file: eslint.sarif
7768
category: eslint
7869

70+
# Verifying the PR checks are up-to-date requires Node 24. The PR checks are not dependent
71+
# on the main codebase and therefore do not need to be run as part of the same matrix that
72+
# we use for the `unit-tests` job.
73+
verify-pr-checks:
74+
name: Verify PR checks
75+
if: github.triggering_actor != 'dependabot[bot]'
76+
permissions:
77+
contents: read
78+
runs-on: ubuntu-slim
79+
timeout-minutes: 10
80+
81+
steps:
82+
- name: Prepare git (Windows)
83+
if: runner.os == 'Windows'
84+
run: git config --global core.autocrlf false
85+
86+
- name: Checkout repository
87+
uses: actions/checkout@v6
88+
89+
- name: Set up Node.js
90+
uses: actions/setup-node@v6
91+
with:
92+
node-version: 24
93+
cache: 'npm'
94+
95+
- name: Verify PR checks up to date
96+
if: always()
97+
run: .github/workflows/script/verify-pr-checks.sh
98+
99+
- name: Run pr-checks tests
100+
if: always()
101+
working-directory: pr-checks
102+
run: npm ci && npx tsx --test
103+
79104
check-node-version:
80105
if: github.triggering_actor != 'dependabot[bot]'
81106
name: Check Action Node versions

0 commit comments

Comments
 (0)