Prevent linkification when replacing an URL

Author: steffen

src/paste-markdown-link.ts

@@ -22,6 +22,9 @@ function onPaste(event: ClipboardEvent) {
 
   const selectedText = field.value.substring(field.selectionStart, field.selectionEnd)
   if (!selectedText.length) return
+  // Prevent linkification when replacing an URL
+  // Trim whitespace in case whitespace is selected by mistake or by intention
+  if (isURL(selectedText.trim())) return
 
   event.stopPropagation()
   event.preventDefault()

test/test.js

@@ -31,6 +31,16 @@ describe('paste-markdown', function () {
       assert.equal(textarea.value, 'The examples can be found [here](https://github.com).')
     })
 
+    it('turns pasted urls on selected urls not into markdown links', function () {
+      // eslint-disable-next-line i18n-text/no-en
+      textarea.value = 'The examples can be found here: https://docs.github.com'
+      textarea.setSelectionRange(32, 55)
+      paste(textarea, {'text/plain': 'https://github.com'})
+      // Synthetic paste events don't manipulate the DOM. The same textarea value
+      // means that the event handler didn't fire and normal paste happened.
+      assert.equal(textarea.value, 'The examples can be found here: https://docs.github.com')
+    })
+
     it('turns html tables into markdown', function () {
       const data = {
         'text/html': `