Get and display all workflows, all jobs per workflow, and last 100 workflow runs in the extension view #110
Conversation
|
Based on the screenshot in #72, the issue was about the number of jobs shown for a given workflow run. This is a different api. Likely this user is running into friction with the default page size of the workflow jobs api |
KetchupOnMyKetchup
changed the title
jtamsut
left a comment
jtamsut
left a comment
There was a problem hiding this comment.
This looks pretty reasonable to me. Thanks for the screenshots in the PR description. Made understanding the problem very clear. 😄
There was a problem hiding this comment.
This PR adds changes to increase page size for workflow runs and fetch all jobs for a workflow run/ workflow run attempt as stated in the PR description 👍
However I don't see any changes to fetch all workflows. Workflows are fetched in WorkflowRepoNode
All workflows are getting fetched already and I put a screenshot in the description to show the code that does it and that I tested it: |
Closes #72
New requirement:
--
Proof of each of the above 3 requirements:
Get all workflows and paginate using octokit is already happening so no code changes were needed. For proof: see screenshot of use of
.paginatepulling all 33 workflows from a repo and paginating (also tested changingper_page: 10to ensure it would still get all 33 workflows and it did):Get all jobs per run and paginate using oktokit. I set per page to 2 in the screenshot below to test and show that it gets all the pages with the
.paginatecode and pulls more than 2 jobs on the right of the screen under a run under both Current Branch and Workflows.Get the last 100 workflow runs demo, by bumping
per_pageto 100 for workflows for the current branch.:--
Demo showing that workflows, runs, and jobs tree working:
